Add Go and Rust BECs to the catalog#15
Conversation
📝 WalkthroughWalkthroughTwo new blocking BEC rules are added to the catalog: Go and Rust no-debug BEC rules
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@becs/no-debug-go.bec.yaml`:
- Around line 9-10: The Go rule is currently matching test files as well as
production code, so scope the file selection in the rule configuration to
exclude `*_test.go` and keep it limited to production `.go` files. Update the
glob or add an explicit test-file exclusion in the `paths` section so the rule
only applies where intended.
In `@becs/no-debug-rust.bec.yaml`:
- Around line 9-10: The Rust path glob is currently too broad and matches test
files as well as production code. Update the paths configuration in this rule to
target only the production Rust tree or explicitly exclude test locations, using
the existing paths entry in the no-debug-rust rule so it no longer applies to
test sources.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 15070637-c095-4b2c-81f0-150e964e9e19
📒 Files selected for processing (3)
becs/README.mdbecs/no-debug-go.bec.yamlbecs/no-debug-rust.bec.yaml
| paths: | ||
| - "**/*.go" |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
git ls-files becs | sed -n '1,200p'
printf '\n--- becs/no-debug-go.bec.yaml ---\n'
cat -n becs/no-debug-go.bec.yaml
printf '\n--- search for no-debug-go references ---\n'
rg -n "no-debug-go|paths:|\\*\\*/\\*\\.go|_test\\.go" becs . -g '*.yaml' -g '*.yml' -g '*.bec.yaml' -g '*.bec.yml' || trueRepository: DataDave-Dev/becwright
Length of output: 2010
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "noop"Repository: DataDave-Dev/becwright
Length of output: 165
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf '%s\n' "Need to inspect the BEC file and related rule definitions."Repository: DataDave-Dev/becwright
Length of output: 219
Scope the Go rule to production files. **/*.go also matches *_test.go, so this rule will fire in tests even though the intent and rationale are production-only. Narrow the glob or add an explicit test-file exclusion.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@becs/no-debug-go.bec.yaml` around lines 9 - 10, The Go rule is currently
matching test files as well as production code, so scope the file selection in
the rule configuration to exclude `*_test.go` and keep it limited to production
`.go` files. Update the glob or add an explicit test-file exclusion in the
`paths` section so the rule only applies where intended.
| paths: | ||
| - "**/*.rs" |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf 'Files matching becs/no-debug-rust.bec.yaml and nearby docs:\n'
git ls-files 'becs/no-debug-rust.bec.yaml' 'becs/*' 'README.md' | sed -n '1,120p'
printf '\nOutline of becs/no-debug-rust.bec.yaml if supported:\n'
if command -v ast-grep >/dev/null 2>&1; then
ast-grep outline becs/no-debug-rust.bec.yaml || true
fi
printf '\nContents of becs/no-debug-rust.bec.yaml with line numbers:\n'
cat -n becs/no-debug-rust.bec.yaml
printf '\nSearch for no-debug-rust references and glob/docs about tests:\n'
rg -n "no-debug-rust|paths:|\\*\\*/\\*\\.rs|test files|tests?" becs README.md .github . -g '!**/.git/**' || trueRepository: DataDave-Dev/becwright
Length of output: 15600
Scope the Rust rule to production files. This glob applies to all Rust files, including tests. If the rule is meant for production code only, narrow it to the production tree or exclude test paths.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@becs/no-debug-rust.bec.yaml` around lines 9 - 10, The Rust path glob is
currently too broad and matches test files as well as production code. Update
the paths configuration in this rule to target only the production Rust tree or
explicitly exclude test locations, using the existing paths entry in the
no-debug-rust rule so it no longer applies to test sources.
2 participants
Summary
Adds two new BEC catalog bundles:
no-debug-go.bec.yamlno-debug-rust.bec.yamlAlso updates
becs/README.mdto include the new catalog entries and language path information.Related Issue
Closes #9
Summary by CodeRabbit