Merge bitcoin-core/gui#771: Avoid error-prone leading whitespace in translatable strings by DashCoreAutoGuix · Pull Request #974 · DashCoreAutoGuix/dash

DashCoreAutoGuix · 2025-08-05T07:11:52Z

Original commit: 64879f4

Backported from Bitcoin Core v0.27

Summary by CodeRabbit

New Features
- Added a new fuzz test for orphan transaction handling.
- Introduced a script to lint Qt translatable strings for leading whitespace.
Bug Fixes
- Improved error handling and validation in wallet upgrade and RPC commands.
- Enhanced wallet transaction addition to prevent inconsistent state on database write failures.
- Updated tests to ensure correct error codes and messages for wallet passphrase errors and invalid port values in RPC calls.
Refactor
- Centralized orphan transaction synchronization and processing, replacing global locks with internal mutexes and per-peer work sets.
- Simplified and clarified HD wallet upgrade logic.
- Updated coin selection and transaction rendering for better code clarity and consistency.
Tests
- Added and updated test cases for orphan transaction handling, wallet upgrades, database write failures, and RPC validation.
- Removed a utility function for generating confirmed UTXOs in test framework.
Documentation
- Improved and clarified method documentation in wallet and system modules.
Chores
- Updated build scripts and CI to include new test targets and linting steps.
- Adjusted debug logging configuration for test nodes.

…rn void

… OOM

Going through the vin and then adding the vin index as a vout position shouldn't work, especially if there are an unequal number of inputs and outputs but the test transactions tend to have spend patterns that allow the code to inadvertently work, evading detection. A new test has been added that uses a spend pattern that would've netted unexpected behavior in the previous logic. Also, we can just use `AddChildrenToWorkSet` for this because it effectively implements the same logic (going through vout, finding and inserting).

Both functions that manipulate it, `AddTx()` and `LimitOrphans()` hold the mutex.

This commit will not compile as-is as block based orphan reprocessing, a Dash-ism, has not been adapted to work with this refactor. That has been segmented out into a separate commit to aid in review.

… members

…ing chain sync

…ror to cpp

…ate datadir fb0dbe9 docs: GetDataDirNet and GetDataDirBase don't create datadir (stickies-v) Pull request description: Since bitcoin#27073, the behaviour of `GetDataDir()` [changed](https://github.com/bitcoin/bitcoin/pull/27073/files#diff-19427b0dd1a791adc728c82e88f267751ba4f1c751e19262cac03cccd2822216L435-L443) to only return the datadir path, but not create it if non-existent. This also changed the behaviour of `GetDataDirNet()` and `GetDataDirBase()` but the docs do not yet reflect that. ACKs for top commit: TheCharlatan: ACK fb0dbe9 theStack: ACK fb0dbe9 willcl-ark: ACK fb0dbe9 Tree-SHA512: 3f10f4871df59882f3649c6d3b2362cae2f8a01ad0bd0c636c5608b0d177d279a2e8712930b819d6d3912e91fa6447b9e54507c33d8afe427f7f39002b013bfb

…coin#25641, bitcoin#25683, bitcoin#23679, bitcoin#26216, bitcoin#26295, bitcoin#26513, bitcoin#26515, bitcoin#26727, bitcoin#25374, bitcoin#25272, bitcoin#26408, bitcoin#25112, bitcoin#26702, bitcoin#25932, bitcoin#26822 (auxiliary backports: part 27) f45de22 merge bitcoin#26822: don't allow past absolute timestamp in `setban` (Kittywhiskers Van Gogh) 920e85d test: adjust mocktime bump to match upstream in `p2p_disconnect_ban` (Kittywhiskers Van Gogh) b1a95d8 merge bitcoin#25932: Simplify backtrack logic (Kittywhiskers Van Gogh) eff27a4 merge bitcoin#26702: drop unused `FindWalletTx` parameter and rename (Kittywhiskers Van Gogh) 62998f3 merge bitcoin#25112: Move error message formatting of NonFatalCheckError to cpp (Kittywhiskers Van Gogh) 27db044 merge bitcoin#26408: Remove spam from debug log (Kittywhiskers Van Gogh) 12acde7 merge bitcoin#25272: guard and alert about a wallet invalid state during chain sync (Kittywhiskers Van Gogh) 385306d merge bitcoin#25374: remove unused `create_confirmed_utxos` helper (Kittywhiskers Van Gogh) a8d29f9 merge bitcoin#26727: remove optional from fStateStats fields (Kittywhiskers Van Gogh) a0701e9 merge bitcoin#26515: skip getpeerinfo for a peer without CNodeStateStats (Kittywhiskers Van Gogh) c9eedc8 merge bitcoin#26513: Make static nLastFlush and nLastWrite Chainstate members (Kittywhiskers Van Gogh) 859d64e txorphanage: adapt block-based orphan reprocessing to refactor (Kittywhiskers Van Gogh) 4172102 merge bitcoin#26295: Replace global g_cs_orphans lock with local (Kittywhiskers Van Gogh) 3665919 fix: protect `m_orphan_tx_size` with `g_cs_orphans` (Kittywhiskers Van Gogh) f12e6cc fix: scan outputs in `GetCandidatesForBlock`, add regression test (Kittywhiskers Van Gogh) 42aa8a7 merge bitcoin#26216: Limit outpoints.size in txorphan target to avoid OOM (Kittywhiskers Van Gogh) b376c09 merge bitcoin#23679: Sanitize port in `addpeeraddress()` (Kittywhiskers Van Gogh) cd6c2b5 merge bitcoin#25683: log `nEvicted` message in LimitOrphans then return void (Kittywhiskers Van Gogh) 6cd09ef merge bitcoin#25641: Fix `-Wparentheses` gcc warning (Kittywhiskers Van Gogh) bc69f80 merge bitcoin#25624: Fix assert bug in txorphan target (Kittywhiskers Van Gogh) fc68188 merge bitcoin#25447: add low-level target for txorphanage (Kittywhiskers Van Gogh) Pull request description: ## Additional information * Since [dash#3121](dashpay#3121), Dash has limited the orphan transaction map by the accumulated size of all transactions in the map instead of transaction count (like upstream). [bitcoin#25447](bitcoin#25447) introduces a new fuzzing harness that operates on upstream assumptions. To bridge the gap, `DEFAULT_MAX_ORPHAN_TRANSACTIONS` has been defined in the harness to mean the highest transaction count _assuming_ each transaction is of maximum size, which means the effective worst-case count is 100 transactions. This is already documented in `net_processing.h` ([source](https://github.com/dashpay/dash/blob/bd589dd6f434c0c6cc8f0c3e2cf299785bad6d07/src/net_processing.h#L31-L32)) but has also been explicitly documented for the harness ([source](https://github.com/dashpay/dash/blob/fc68188e3227dc0912ef3c508f6d45ff1d7614ee/src/test/fuzz/txorphan.cpp#L27-L28)). * Dash introduced an additional trigger for orphan reprocessing in [dash#3139](dashpay#3139) to allow for faster processing when parents appear in a block. Currently, the implementation scans through the _inputs_ of each transaction to check against the outpoint map ([source](https://github.com/dashpay/dash/blob/86071f9df4d052de6f1df64a5d269a67a6756d29/src/txorphanage.cpp#L186-L192)). This does not seem to be intended behavior as it's using the input index to search through outpoints when it should be iterating through outpoints like `AddChildrenToWorkSet()` ([source](https://github.com/dashpay/dash/blob/86071f9df4d052de6f1df64a5d269a67a6756d29/src/txorphanage.cpp#L148C19-L159)). Though despite this, the code still worked _if_ either of the following conditions were met. * There are an even number of inputs and outputs (in which case a match is found as if iterating through the set of outputs); or * There are more inputs than outputs (in which case a match is found even if all `find()`s `i > vout.size()` are wasted operations) The test case introduced in [dash#3139](dashpay#3139) met this criteria and passed though the code would _not_ work as expected if * There are more outputs than inputs (in which case the loop will bail prematurely as `vin.size() > vout.size()` and we're scanning `vins` for outpoint positions) This has been rectified by modifying `GetCandidatesForBlock()` to use `AddChildrenToWorkSet()` and adding a unit test to document this behavior. * [bitcoin#26295](bitcoin#26295) does a substantial refactor of the transaction "orphanage" and part of that refactor is solidifying `ProcessOrphanTx()` as dealing with `Peer`s (as it's located in `net_processing` and not available through the interface). This conflicts with the capability introduced in [dash#3139](dashpay#3139) as there is no peer to attribute it to, which is relevant as the newer code introduces a map between peer ID and the orphan work map ([source](https://github.com/bitcoin/bitcoin/blob/7082ce3e88d77456d60a5a66bd38807fbd66f311/src/txorphanage.h#L75-L76)). This has been worked around by using the ID `-1` to mean block connection triggered orphan work ([source](https://github.com/dashpay/dash/blob/859d64e98fc1b5bf613f526ef76e5fc66851fe13/src/txorphanage.cpp#L204-L209), [source](https://github.com/dashpay/dash/blob/859d64e98fc1b5bf613f526ef76e5fc66851fe13/src/net_processing.cpp#L2015-L2024)). This is because no valid peer can be assigned a negative ID as it starts from 0 ([source](https://github.com/dashpay/dash/blob/bd589dd6f434c0c6cc8f0c3e2cf299785bad6d07/src/net.h#L1735)) and increments ([source](https://github.com/dashpay/dash/blob/bd589dd6f434c0c6cc8f0c3e2cf299785bad6d07/src/net.cpp#L3897-L3900)). An example of this kind of usage is InstantSend code ([source](https://github.com/dashpay/dash/blob/859d64e98fc1b5bf613f526ef76e5fc66851fe13/src/instantsend/signing.cpp#L252)). * This change, alongside relevant changes to `ProcessOrphanTx()` arguments and other Dash-specific code has been segmented out as a distinct commit to allow for ease of review. This also means that the commit that backports [bitcoin#26295](bitcoin#26295) cannot be compiled on its own due to build errors from not-yet adapted code. * Additionally, `ProcessOrphanTx()` assumes `Peer`-triggered orphan resolution and doesn't account for the possibility that the processing of a transaction may further populate the orphan set. This is a key assumption in block-based orphan processing and to retain this intended functionality, `TxOrphanage::HaveMoreWork()` has been defined to influence the return value of `ProcessOrphanTx()` to affect the resolution loop ([source](https://github.com/dashpay/dash/blob/859d64e98fc1b5bf613f526ef76e5fc66851fe13/src/net_processing.cpp#L2015-L2024)) to exhaust all work before continuing ahead. ## Breaking changes None expected. ## Checklist - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have added or updated relevant unit/integration/functional/e2e tests - [x] I have made corresponding changes to the documentation **(note: N/A)** - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: knst: utACK f45de22 UdjinM6: utACK f45de22 Tree-SHA512: 8f6a46984091d6f43d4fb97d13edc9dfa7affa1eb79ab37e14f49078b5d738308c6044f9b2b3f5e0d1fe2efde27b7bae14727e14e1ccd5d21eb695162d9c4615

…GetDataDirBase don't create datadir c5b325a Merge bitcoin#27176: docs: GetDataDirNet and GetDataDirBase don't create datadir (fanquake) Pull request description: ## Issue being fixed or feature implemented Since bitcoin#27073 (backported via dashpay#6780), the behaviour of `GetDataDir()` [changed](https://github.com/bitcoin/bitcoin/pull/27073/files#diff-19427b0dd1a791adc728c82e88f267751ba4f1c751e19262cac03cccd2822216L435-L443) to only return the datadir path, but not create it if non-existent. This also changed the behaviour of `GetDataDirNet()` and `GetDataDirBase()` but the docs do not yet reflect that. ## How Has This Been Tested? N/A ## Breaking Changes N/A ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [x] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: UdjinM6: utACK c5b325a PastaPastaPasta: utACK c5b325a Tree-SHA512: ff3fa0daea16ddc2d4140e65b7a02926fa2be9adebd6f756868ca985c49a9963950ba1ced1117b3ca289cdda6c7d44e72f51158ced1d3abb5e2f965b81f00896

…ohd` rpc 746e5f8 fix: always leave the wallet in a locked state afer `upgradetohd` (UdjinM6) b19f463 fix(rpc): return correct error codes in `upgradetohd` rpc (UdjinM6) Pull request description: ## Issue being fixed or feature implemented `upgradetohd` rpc returns wrong error codes ## What was done? Move wallet "upgrade to HD" code used in rpc only to `upgradetohd` rpc, return correct error codes. We also don't need all that logic to extract wallet master encryption key because it's already known when wallet is unlocked. ## How Has This Been Tested? Run tests ## Breaking Changes `upgradetohd` should return correct error codes now which could probably break things if you relied on them, see tests ## Checklist: - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [ ] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: knst: utACK 746e5f8 Tree-SHA512: 829d1f9d805f7a87f628a9c7f4ae93cb545c8113cea97f430639165dae124db17d389c2f5c663214b074da8ae541435ab7df2b672f78370fe883ac77b3cfed42

…ranslatable strings 856325f lint: Add `lint-qt-translation.py` (Hennadii Stepanov) 294a018 qt: Avoid error prone leading spaces in translatable strings (Hennadii Stepanov) d8298e7 qt, refactor: Drop superfluous type conversions (Hennadii Stepanov) Pull request description: While working on the GUI translation via Transifex web interface, I found it error-prone to have leading whitespace in translatable strings. This is because it is very easy to unintentionally drop them in translations unnoticed. Fixed all current cases. Added a linter to prevent similar cases in the future. ACKs for top commit: furszy: utACK 856325f Tree-SHA512: b1ca5effb2db6649e1e99382de79acf3a9f81cc9dad434db5623338489e597897e8addd60c1ab3dcc7506ae62753a7a4ad5a41d7a865f8fcdf94348b54baa7e7

coderabbitai · 2025-08-05T07:15:50Z

Walkthrough

This update introduces significant refactoring and testing improvements to orphan transaction handling, wallet HD upgrade logic, and error reporting. The orphanage logic is overhauled for per-peer work sets and internal mutex locking, with corresponding changes in processing, tests, and fuzz targets. Wallet code removes legacy HD upgrade methods, improving error handling and test coverage for transaction addition and upgrade failures. Additional changes include enhancements to RPC error checks, new and revised tests, a new translation lint script, and minor documentation and formatting updates.

Changes

Cohort / File(s)	Change Summary
Orphanage Refactor `src/txorphanage.cpp`, `src/txorphanage.h`, `src/net_processing.cpp`, `src/init.cpp`, `src/test/fuzz/process_message.cpp`, `src/test/fuzz/process_messages.cpp`, `src/test/orphanage_tests.cpp`, `src/test/fuzz/txorphan.cpp`, `src/Makefile.test.include`	Refactored orphan transaction management: replaced global mutex with internal class mutex, introduced per-peer work sets, updated APIs, simplified locking, and added a new fuzz target and test case for orphanage logic.
Wallet HD Upgrade and Error Handling `src/wallet/wallet.cpp`, `src/wallet/wallet.h`, `src/wallet/rpc/wallet.cpp`, `src/wallet/test/wallet_tests.cpp`	Removed legacy HD upgrade methods, refactored wallet creation and upgrade logic, improved error handling for transaction addition, and added a new test for database write failures.
Wallet Database API Update `src/wallet/walletdb.cpp`, `src/wallet/walletdb.h`	Renamed and simplified wallet database method: `FindWalletTx` → `FindWalletTxHashes`, removing deserialization of wallet transactions.
Error Reporting Refactor `src/util/check.cpp`, `src/util/check.h`	Simplified error reporting: removed formatted error messages and dependencies, introduced explicit exception construction.
Validation State Tracking `src/validation.cpp`, `src/validation.h`	Replaced static local variables for last write/flush times with `CChainState` member variables.
Qt Transaction Rendering `src/qt/psbtoperationsdialog.cpp`, `src/qt/psbtoperationsdialog.h`	Changed transaction rendering to use `QString` and HTML formatting for improved UI integration.
Qt Send Dialog Formatting `src/qt/sendcoinsdialog.cpp`	Improved wallet name formatting in send confirmation dialog, ensuring HTML escaping.
RPC and Test Enhancements `src/rpc/net.cpp`, `test/functional/p2p_disconnect_ban.py`, `test/functional/rpc_net.py`, `test/functional/wallet_upgradetohd.py`	Improved RPC error handling and documentation, added/updated tests for ban timestamp validation, invalid peer address ports, and wallet upgrade error codes.
Test Framework and Linting `test/functional/test_framework/test_node.py`, `test/functional/test_framework/util.py`, `test/lint/lint-qt-translation.py`	Added debug exclusion for randomness, removed UTXO creation helper, and introduced a new lint script for Qt translation string whitespace.
Documentation and Comments `src/util/system.h`	Removed postcondition comments from `ArgsManager` methods.

Estimated code review effort

🎯 5 (Critical) | ⏱️ ~70 minutes

Complexity: High. The orphanage refactor and wallet HD upgrade changes are intricate, affecting core logic, locking, and interfaces, and require careful review for concurrency and correctness. Multiple new/altered tests and fuzz targets increase review breadth. Other changes are moderate to low in complexity but numerous.
Volume: High, with changes spanning many files and touching core, wallet, RPC, Qt, and test code.
Estimated review time: ~70 minutes, accounting for the need to verify concurrency, state transitions, error handling, and test coverage.

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch backport-0.27-batch-679-pr-771

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 9

🔭 Outside diff range comments (5)

src/rpc/net.cpp (1)

243-270: Mandatory fields implemented correctly

All peer state fields are now included unconditionally, implementing the API consistency improvement.

The TODO comment on line 256 mentions that banscore removal may be blocked by p2p_quorum_data.py usage. Would you like me to create an issue to track the removal of this deprecated field?

src/test/orphanage_tests.cpp (1)

23-185: VALIDATION: FAIL - Unrelated orphan transaction changes

These orphan transaction handling changes are completely unrelated to the stated PR objective of fixing whitespace in translatable strings from bitcoin-core/gui#771.

Expected: Changes to GUI files removing leading whitespace from translatable strings
Actual: Orphan transaction mutex refactoring and new test cases

This confirms the validation failure - wrong changes are being backported under an incorrect PR title.
src/net_processing.cpp (1)
3355-3365: Potential message processing starvation from orphan handling

The early return when has_more_orphans is true (line 3364) could potentially starve other message processing if a peer has many orphans queued. This might allow a malicious peer to prevent processing of other messages by flooding orphan transactions.

Consider implementing a limit on consecutive orphan processing or processing other messages before returning to orphans.
+    static constexpr size_t MAX_ORPHANS_PER_CYCLE = 10;
+    size_t orphans_processed = 0;
     bool has_more_orphans;
     {
         LOCK(cs_main);
-        has_more_orphans = ProcessOrphanTx(peer->m_id);
+        // Process up to MAX_ORPHANS_PER_CYCLE to prevent starvation
+        while (orphans_processed < MAX_ORPHANS_PER_CYCLE) {
+            has_more_orphans = ProcessOrphanTx(peer->m_id);
+            if (!has_more_orphans) break;
+            orphans_processed++;
+        }
     }

     if (pfrom->fDisconnect)
         return false;

-    if (has_more_orphans) return true;
+    // Continue with other message processing even if more orphans exist
src/txorphanage.cpp (1)

1-249: VALIDATION: FAIL - Complete mismatch between PR objectives and actual changes

The PR claims to backport bitcoin-core/gui#771 about "Avoid error-prone leading whitespace in translatable strings", but the actual changes are a massive refactoring of orphan transaction handling with:

Global mutex g_cs_orphans → internal m_mutex

New per-peer work sets (m_peer_work_set)

Complete API changes (e.g., GetTx → GetTxToReconsider)

New methods like SetCandidatesByBlock, HaveMoreWork

This appears to be a completely different Bitcoin Core PR. Please verify:

Are these the correct files for PR #974?

Is this actually backporting a different Bitcoin commit related to orphanage refactoring?

Was the wrong PR objective provided?

src/txorphanage.h (1)

1-111: File changes don't match stated PR objective

This header file shows the same orphanage refactoring that doesn't align with the stated objective of fixing "leading whitespace in translatable strings" from bitcoin-core/gui#771.

The changes here are consistent with the implementation file but completely unrelated to GUI translation strings.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7b83b48 and cb4d0e2.

📒 Files selected for processing (32)

ci/dash/lint-tidy.sh (1 hunks)
src/Makefile.test.include (1 hunks)
src/init.cpp (0 hunks)
src/net_processing.cpp (13 hunks)
src/qt/psbtoperationsdialog.cpp (3 hunks)
src/qt/psbtoperationsdialog.h (2 hunks)
src/qt/sendcoinsdialog.cpp (1 hunks)
src/rpc/net.cpp (8 hunks)
src/test/fuzz/process_message.cpp (0 hunks)
src/test/fuzz/process_messages.cpp (0 hunks)
src/test/fuzz/txorphan.cpp (1 hunks)
src/test/orphanage_tests.cpp (2 hunks)
src/txorphanage.cpp (8 hunks)
src/txorphanage.h (4 hunks)
src/util/check.cpp (1 hunks)
src/util/check.h (2 hunks)
src/util/system.h (0 hunks)
src/validation.cpp (4 hunks)
src/validation.h (2 hunks)
src/wallet/coinselection.cpp (1 hunks)
src/wallet/rpc/wallet.cpp (1 hunks)
src/wallet/test/wallet_tests.cpp (1 hunks)
src/wallet/wallet.cpp (2 hunks)
src/wallet/wallet.h (1 hunks)
src/wallet/walletdb.cpp (3 hunks)
src/wallet/walletdb.h (1 hunks)
test/functional/p2p_disconnect_ban.py (2 hunks)
test/functional/rpc_net.py (1 hunks)
test/functional/test_framework/test_node.py (1 hunks)
test/functional/test_framework/util.py (0 hunks)
test/functional/wallet_upgradetohd.py (1 hunks)
test/lint/lint-qt-translation.py (1 hunks)

💤 Files with no reviewable changes (5)

src/test/fuzz/process_messages.cpp
src/test/fuzz/process_message.cpp
src/util/system.h
src/init.cpp
test/functional/test_framework/util.py

🧰 Additional context used

📓 Path-based instructions (6)

**

⚙️ CodeRabbit Configuration File

**: # CodeRabbit AI Review Instructions for Dash Backports

Your Role

You are reviewing Bitcoin Core backports to Dash Core. Your ONLY job is to validate that the Dash commit faithfully represents the original Bitcoin commit with minimal, necessary adaptations.

Critical Validation Rules

1. File Operations Must Match (AUTO-REJECT if violated)

If Bitcoin modifies an existing file → Dash MUST modify (not create new)

If Bitcoin creates a new file → Dash creates

If Bitcoin deletes a file → Dash deletes

Common failure: Bitcoin modifies keys.txt, Dash creates new file with 58 keys

2. Size Ratio Check (80-150% of Bitcoin)

Count functional lines changed (exclude comments/whitespace)

Dash changes should be 80-150% of Bitcoin's size

Red flag: 2-line Bitcoin fix becoming 150+ lines in Dash

3. No Scope Creep

Reject if you see: "TODO:", "FIXME:", "while we're here", "also fix"

No unrelated refactoring or style changes

Only Bitcoin's intended changes + minimal Dash adaptations

4. Bitcoin-Specific Code Detection

Auto-reject witness/segwit code: msg_wtxidrelay, MSG_WTX, witness imports

Auto-reject RBF (replace-by-fee) functionality

Note: PSBT is supported in Dash (don't flag)

5. Mandatory Adaptations Only

bitcoin → dash in strings/paths

Bitcoin → Dash in user-facing text

Port numbers: 8332→9998 (RPC), 8333→9999 (P2P)

Hardcoded test values specific to Dash

No other changes unless absolutely required

6. Completeness Check

All files changed in Bitcoin must be present

Extra files need clear justification (Dash-specific compatibility)

Missing files = incomplete backport

Review Process

First: Check file operations match exactly

Second: Calculate size ratio

Third: Scan for scope creep patterns

Fourth: Detect Bitcoin-specific code

Fifth: Verify all changes are minimal adaptations

Output Format
VALIDATION: [PASS/FAIL]

File Operatio...

Files:

src/Makefile.test.include
src/wallet/coinselection.cpp
test/functional/test_framework/test_node.py
src/qt/sendcoinsdialog.cpp
test/functional/wallet_upgradetohd.py
test/functional/p2p_disconnect_ban.py
src/util/check.cpp
test/lint/lint-qt-translation.py
ci/dash/lint-tidy.sh
src/wallet/walletdb.h
src/validation.h
src/qt/psbtoperationsdialog.h
src/qt/psbtoperationsdialog.cpp
src/test/orphanage_tests.cpp
src/test/fuzz/txorphan.cpp
src/wallet/wallet.h
src/rpc/net.cpp
src/wallet/walletdb.cpp
src/wallet/test/wallet_tests.cpp
src/util/check.h
src/validation.cpp
src/wallet/wallet.cpp
src/net_processing.cpp
src/wallet/rpc/wallet.cpp
test/functional/rpc_net.py
src/txorphanage.h
src/txorphanage.cpp

src/**/*.{cpp,h,cc,cxx,hpp}