Add StringRef pointer + length constructor

[slipher]

No description provided.

[illwieckz]

src/common/String.h: In instantiation of ‘Str::BasicStringRef<T>::BasicStringRef(const T*, size_t) [with T = char; size_t = long unsigned int]’:
GeneratedSource/DaemonEmbeddedFiles/EngineShaders/common_glsl.h:349:1:   required from here
src/common/String.h:58:29: error: ‘DAEMON_ASSERT_EQ’ was not declared in this scope
   58 |             DAEMON_ASSERT_EQ(start[len], '\0');
      |             ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
src/common/String.h:58:29: note: the macro ‘DAEMON_ASSERT_EQ’ had not yet been defined
In file included from src/common/Common.h:46:
src/common/Assert.h:115: note: it was later defined here
  115 | #define DAEMON_ASSERT_EQ(a, b) DAEMON_ASSERT_CALLSITE( \
      | 

[illwieckz]

You have to add:

#include "Assert.h"

[illwieckz]

You have to add:

#include "Assert.h"

Or maybe move that include in Common.h before #include "String.h".

[illwieckz]

Or maybe move that include in Common.h before #include "String.h".

I have a commit doing that in my branch, it works.

Better solution found.

[illwieckz]

Hu, no now on MinGW it says String.h should be included before Assrert.h.

[illwieckz]

DAEMON_ASSERT_EQ in Assert.h uses Str::Format() from String.h,
but Str::BasicStringRef from String.hnow requiresDAEMON_ASSERT_EQfromAssert.h`.

[slipher]

Well that's annoying. I checked that it compiles locally before making the PR. I guess there must be a problem when PCH is off. Maybe due to some .cpp file that doesn't include Common.h first

[illwieckz]

Maybe due to some .cpp file that doesn't include Common.h first

Yes, the generated embedded files. Actually I'm a bit annoyed to add the whole src/common folder has a dependency for the code generation (same critique for using Str::StringRef there to begin with). My small struct is very portable and doesn't pull a whole folder of header files, so I prefer that. I can reuse the cast trick to avoid exposing an unsigned char array though.