Skip to content

Fix some deprecated std stuff#1718

Merged
VReaperV merged 4 commits intoDaemonEngine:masterfrom
VReaperV:fix-deprecated
Aug 4, 2025
Merged

Fix some deprecated std stuff#1718
VReaperV merged 4 commits intoDaemonEngine:masterfrom
VReaperV:fix-deprecated

Conversation

@VReaperV
Copy link
Contributor

@VReaperV VReaperV commented Aug 1, 2025

Some fixes for deprecated stuff I did in daemon-vulkan, backported here. These ones don't require any C++ version upgrade.

@VReaperV
Copy link
Contributor Author

VReaperV commented Aug 1, 2025

MacOS compiler in the CI is being a piece of shit for some reason.

@slipher
Copy link
Member

slipher commented Aug 3, 2025

MacOS compiler in the CI is being a piece of shit for some reason.

We saw this CI glitch in #1687 as well, where the compiler acts like it is in C++11 mode. I tried locally with AppleClang 17.0 and was unable to reproduce the issue: the std=gnu++14 is passed and it builds without issues. The CI build log shows the respective flag test passing, so it should be used there too. Maybe we should try upgrading the VM image in azure-pipelines.yml. It's using AppleClang 15.0 so the bug could be fixed in a newer version.

@VReaperV
Copy link
Contributor Author

VReaperV commented Aug 3, 2025

MacOS compiler in the CI is being a piece of shit for some reason.

We saw this CI glitch in #1687 as well, where the compiler acts like it is in C++11 mode. I tried locally with AppleClang 17.0 and was unable to reproduce the issue: the std=gnu++14 is passed and it builds without issues. The CI build log shows the respective flag test passing, so it should be used there too. Maybe we should try upgrading the VM image in azure-pipelines.yml. It's using AppleClang 15.0 so the bug could be fixed in a newer version.

I tried macOS-latest earlier, CI still had the same issue unfortunately :/

@VReaperV
Copy link
Contributor Author

VReaperV commented Aug 3, 2025

Hmm, maybe not? The CI still used AppleClang 15 I think, the one on macOS-latest should be AppleClang 18.

@VReaperV
Copy link
Contributor Author

VReaperV commented Aug 3, 2025

Nah, CI still just uses AppleClang 15.

@slipher
Copy link
Member

slipher commented Aug 3, 2025

Apparently, macOS-latest is not really the latest one. You have to write macOS-15.

@VReaperV
Copy link
Contributor Author

VReaperV commented Aug 3, 2025

Still fails, even though it's using AppleClang 16.

@VReaperV VReaperV mentioned this pull request Aug 4, 2025
@slipher
Copy link
Member

slipher commented Aug 4, 2025

LGTM

@VReaperV VReaperV merged commit 37f979c into DaemonEngine:master Aug 4, 2025
8 checks passed
@VReaperV VReaperV deleted the fix-deprecated branch August 4, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants