Skip to content

Homepage news update for the testathon#1089

Closed
bram-atmire wants to merge 1 commit into
DSpace:mainfrom
bram-atmire:Testathon-homepage-news
Closed

Homepage news update for the testathon#1089
bram-atmire wants to merge 1 commit into
DSpace:mainfrom
bram-atmire:Testathon-homepage-news

Conversation

@bram-atmire
Copy link
Copy Markdown
Member

Description

Reference to the testathon on the homepage
Reference to the test accounts on the homepage

Instructions for Reviewers

Look at the homepage

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes TSLint validation using yarn run lint
  • My PR doesn't introduce circular dependencies
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.

@tdonohue
Copy link
Copy Markdown
Member

tdonohue commented Apr 7, 2021

@bram-atmire : Just a quick note. I like the changes overall, though this will be dependent on @artlowel's simple default "dspace" theme in #1063. So, we'll likely have to wait on that...or bring this idea into that PR (as I think these Testathon-specific homepage news changes should move into the "dspace" default theme anyways).

@tdonohue
Copy link
Copy Markdown
Member

@bram-atmire : I didn't forget about this change! However, I had to rework it slightly in a new PR (#1098) as the changes to the homepage need to be moved into the new "dspace" theme. So, I'm closing this PR in favor of that one. Thanks!

@tdonohue tdonohue closed this Apr 13, 2021
@bram-atmire
Copy link
Copy Markdown
Member Author

Awesome, thank you Tim !!!

atarix83 pushed a commit to 4Science/dspace-angular that referenced this pull request Nov 3, 2025
port GLAM frontend fixes to ux-p

Approved-by: Stefano Maffei
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants