Conversation
myk002
left a comment
There was a problem hiding this comment.
I think I prefer this API to what we had before. I'm not sure if it's perfect, but it's absolutely better. Just stylistic notes, but otherwise looks good.
could you use single quotes around the asset paths? we've mostly standardized on single quotes for strings in our Lua code.
|
wait -- after writing that suggestion of |
That's right! |
|
As I mentioned in main PR, it will be useful and more clear to move assets loading to lua plugin, where we can declare callbacks to get specific asset more centralized. Other plugins and scripts will just use this callbacks. |
Will work with DFHack/dfhack#3663 only.