add small letters and on-off textures in top-left corners of 32x32 tiles#4144
Merged
myk002 merged 3 commits intoDFHack:developfrom Jan 7, 2024
Merged
add small letters and on-off textures in top-left corners of 32x32 tiles#4144myk002 merged 3 commits intoDFHack:developfrom
myk002 merged 3 commits intoDFHack:developfrom
Conversation
myk002
reviewed
Jan 6, 2024
Member
myk002
left a comment
myk002
left a comment
There was a problem hiding this comment.
I suggest names with no spaces in them to match with existing filenames. it also looks like we prefer dashes to underscores
Contributor
Author
|
is |
Member
a combination of dashes and underscores might be appropriate here -- |
Contributor
Author
|
renamed with underscores (on the off chance we want bottom-right etc versions later) |
myk002
approved these changes
Jan 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These will be used in the
gui/biomesscript (DFHack/scripts#637)