Skip to content

Swap out Library sample components for @cratis/components equivalents#377

Open
Copilot wants to merge 5 commits intomainfrom
copilot/swap-library-sample-components
Open

Swap out Library sample components for @cratis/components equivalents#377
Copilot wants to merge 5 commits intomainfrom
copilot/swap-library-sample-components

Conversation

Copy link
Copy Markdown

Copilot AI commented Feb 24, 2026

  • Explore codebase and understand what components exist locally and in @cratis/components
  • Add @cratis/components dependency to Library/package.json
  • Replace AddAuthor.tsx with CommandDialog + InputTextField from @cratis/components
  • Replace AddBook.tsx with CommandDialog + field components from @cratis/components
  • Replace local Components/Common files with re-exports from @cratis/components/Common
  • Replace local Components/Dialogs files with re-exports from @cratis/components/Dialogs
  • Replace local Components/DataTables files with re-exports from @cratis/components/DataTables
  • Replace local Components/DataPage files with re-exports from @cratis/components/DataPage
  • Update DefaultLayout.tsx to import ErrorBoundary directly from @cratis/components/Common
  • Upgrade @cratis/arc, @cratis/arc.react, @cratis/arc.react.mvvm, @cratis/arc.vite to 19.9.1 and @cratis/components to 1.4.1
  • Fix CommandDialog: rename headertitle, remove manual useDialogContext/closeDialog
  • Replace PrimeReact Menubar with Toolbar/ToolbarButton from @cratis/components in Authors/Inventory pages
  • Merge from main - upgraded @cratis/arc* to 19.11.0, resolved package.json conflicts
Original prompt

This section details on the original issue you should resolve

<issue_title>Swap out components in Library sample</issue_title>
<issue_description>Switch to using CommandForm from @cratis/arc.react, documentation can be found here:

https://www.cratis.io/docs/Arc/frontend/react/commands/command-form/index.html

For CommandForm fields, use the ones adapted for PrimeReact in the @cratis/components.
Also remove any components that already exist in @cratis/components and adapt the code to match them. Documentation can be found here:
https://www.cratis.io/docs/Components/index.html</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits February 24, 2026 07:03
Co-authored-by: einari <134365+einari@users.noreply.github.com>
…y sample

Co-authored-by: einari <134365+einari@users.noreply.github.com>
Copilot AI changed the title [WIP] Swap components in Library sample to CommandForm Swap out Library sample components for @cratis/components equivalents Feb 24, 2026
Copilot AI requested a review from einari February 24, 2026 07:08
@einari
Copy link
Copy Markdown
Contributor

einari commented Mar 9, 2026

@copilot Upgrade to the latest of @cratis/arc and @cratis/components and then look through the documentation for whats changed and adapt the code accordingly: https://www.cratis.io/docs/Components/index.html

Co-authored-by: einari <134365+einari@users.noreply.github.com>
Copy link
Copy Markdown
Author

Copilot AI commented Mar 9, 2026

@copilot Upgrade to the latest of @cratis/arc and @cratis/components and then look through the documentation for whats changed and adapt the code accordingly: https://www.cratis.io/d...

Upgraded all @cratis packages to latest (@cratis/arc, @cratis/arc.react, @cratis/arc.react.mvvm, @cratis/arc.vite → 19.9.1; @cratis/components → 1.4.1) and adapted the code to the new APIs (commit 4aa6dd4):

  • CommandDialog: renamed headertitle; removed manual useDialogContext/closeDialog calls since the new Dialog component auto-handles context-based closing
  • Authors/Inventory pages: replaced PrimeReact Menubar with Toolbar/ToolbarButton from @cratis/components/Toolbar, using PrimeIcons CSS class strings and orientation="horizontal"

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • www.cratis.io
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@einari einari marked this pull request as ready for review March 22, 2026 11:56
@einari
Copy link
Copy Markdown
Contributor

einari commented Mar 22, 2026

@copilot merge from main (rebase) and fix conflicts

Copy link
Copy Markdown
Author

Copilot AI commented Mar 22, 2026

@copilot merge from main (rebase) and fix conflicts

Merged from main (commit 485d0d4). The only conflict was in Library/package.json — resolved by keeping @cratis/components: 1.4.1 from our branch and taking the updated @cratis/arc* versions (19.11.0) from main. Build passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Swap out components in Library sample

2 participants