Remove baseclass names from subclass entries. - #326
Merged
Conversation
This prevents such sections as being marked as duplicates.
Cphrampus
previously approved these changes
May 9, 2019
Owner
|
I had not really played around with that flag, I mostly use excludes or includes. Great catch! |
Author
|
Oops, I accidentally pushed the wrong thing to this branch, causing your review to be invalidated. Please review again and feel free to merge. @Cphrampus |
Cphrampus
self-requested a review
May 14, 2019 23:58
Cphrampus
approved these changes
May 14, 2019
Owner
|
Thanks for finding and fixing this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents such sections as being marked as duplicates.
The baseclass
<name>tag in the subclass<class>elements caused subclasses to be marked as duplicates are excluded from the compendium.This happens when using
--subtype-format usable.