Fix: enforce CI gates so untested code cannot ship (H-4) - #432
Merged
Conversation
- release.yml: add a Test gate job (fmt + clippy + cargo test) that the build matrix `needs`, so 5-platform release binaries can no longer be published from a commit that fails tests. - ci.yml: stop cancelling in-progress runs on main (cancel-in-progress now excludes refs/heads/main) so every merged commit gets a completed CI verdict. - ci.yml: add specs/** to the push and pull_request path filters so spec-only PRs trigger the strict spec-check job instead of running no CI at all. Addresses review findings H-4 (no release test gate / cancelled main runs) and the specs/** CI-coverage gap. Branch-protection required-status-checks is a repo-settings change and is intentionally left out of this commit. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016AvsKakjAc3EKN2ztcMfYi
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
❌ Corvin says...
_
<(;\ .oO(oh no...)
|/(\
\(\\
" "\\
"Caw... validation failed..."
CI Summary
| Check | Status |
|---|---|
| Dependency Audit | ❌ failure |
| Integration (3 OS) | ✅ Passed |
| Lint (fmt + clippy) | ✅ Passed |
| Spec Validation | ✅ Passed |
| Tests (3 OS) | ✅ Passed |
Powered by corvid-pet
This was referenced Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release.yml: add a Test gate job (fmt + clippy +cargo test) that the build matrixneeds, so 5-platform release binaries can no longer be published from a commit that fails tests.ci.yml: stop cancelling in-progress runs onmain—cancel-in-progressnow excludesrefs/heads/main, so every merged commit gets a completed CI verdict.ci.yml: addspecs/**to the push and pull_request path filters so spec-only PRs trigger the strict spec-check job instead of running no CI at all.Addresses review finding H-4 (no release test gate / cancelled main runs) and the
specs/**CI-coverage gap. Enabling branch-protection required status checks is a repo-settings change and is intentionally left out of this PR.Test Plan
main(lint,audit,spec-check,test (ubuntu-latest))🤖 Generated with Claude Code
https://claude.ai/code/session_016AvsKakjAc3EKN2ztcMfYi