Skip to content

docs: correct the OpenAI /v1/videos page against the implementation#264

Merged
jpr5 merged 1 commit into
mainfrom
docs/video-page-accuracy
Jun 10, 2026
Merged

docs: correct the OpenAI /v1/videos page against the implementation#264
jpr5 merged 1 commit into
mainfrom
docs/video-page-accuracy

Conversation

@jpr5

@jpr5 jpr5 commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Follow-up from the #262 docs verification: docs/video/index.html described behavior the code does not have. Corrections, verified against src/video.ts and src/types.ts (VideoResponse) on main:

  1. Async Polling Pattern — removed the false claim that aimock returns "processing" on the first poll then "completed" afterward. There is no progression: the create response and every poll echo the fixture's video.status verbatim. Cross-linked the OpenRouter surface (openRouterVideo config) for staged progression.
  2. Unit-test example — the previous example could not pass or typecheck: the onVideo fixture omitted required id/status, used a nonexistent duration field, and asserted a nested pollBody.video.url. Rewritten to compile against VideoResponse and match the real flat poll body {id, status, created_at, url}.
  3. Response Formatcreatedcreated_at on create; poll fields are flat (url, not video.url); removed nonexistent video.duration; added "failed" to the status union.
  4. JSON fixture example — added the required id/status fields, dropped duration.

Also fixed the Record & Replay paragraph, which repeated the lifecycle-simulation claim (recorded in-progress responses replay as "processing" verbatim), and re-verified the #262 cross-link paragraph still reads correctly.

The /v1/videos docs page described behavior the code does not have:

- The "Async Polling Pattern" section claimed aimock returns "processing" on
  the first poll and "completed" on subsequent polls. There is no progression:
  the create response and every poll echo the fixture's video.status verbatim
  (src/video.ts). Staged progression exists only on the OpenRouter surface via
  the openRouterVideo config; the section now cross-links it.
- The unit-test example could not pass or typecheck: the onVideo fixture
  omitted the required id/status fields, used a nonexistent duration field,
  and asserted a nested pollBody.video.url. The poll body is flat
  {id, status, created_at, url}. Rewritten against VideoResponse.
- The "Response Format" section said `created` (it is created_at), `video.url`
  / `video.duration` on poll (flat url; duration does not exist), and omitted
  "failed" from the status union.
- The JSON fixture example had the same missing id/status problem.
- The Record & Replay paragraph repeated the lifecycle-simulation claim;
  recorded in-progress responses replay as "processing" verbatim.
@pkg-pr-new

pkg-pr-new Bot commented Jun 10, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@copilotkit/aimock@264

commit: 467bd38

@jpr5 jpr5 merged commit a9e3c52 into main Jun 10, 2026
13 checks passed
@jpr5 jpr5 deleted the docs/video-page-accuracy branch June 10, 2026 22:19
@jpr5 jpr5 mentioned this pull request Jun 11, 2026
jpr5 added a commit that referenced this pull request Jun 11, 2026
### Added

- OpenRouter async video job lifecycle mock — submit, poll, content download, model listing (#262)
- Record-mode live proxying for the OpenRouter video surface; captured videos replay later (#265)

### Changed

- Recording proxies now strip aimock-internal control headers on every provider path (#265)

### Fixed

- Recorder and fal record paths hardened — timeouts, threshold sanitizing, persist errors (#265)
- attw ^0.18 fixes the test:exports crash (#263); OpenAI /v1/videos docs corrected (#264)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant