Conversation
Add Boolean active field to ConstructorItem and ConstructorVariation classes to support marking items and variations as active/inactive. Include getter/setter methods and ensure the field is properly serialized in the toMap() method. Add comprehensive tests verifying that: - Active field is included in serialized output when set - Active field defaults to null when not set - Getter/setter methods work correctly for both true and false values 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds an active field to the ConstructorItem and ConstructorVariation classes to allow tracking of item/variation active status.
- Added
Boolean activefield with getter/setter methods to both classes - Updated
toMap()methods to include the active field in the data map - Added comprehensive test coverage for the new active field functionality
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| ConstructorItem.java | Added active field, getter/setter, and serialization to data map |
| ConstructorVariation.java | Added active field, getter/setter, and serialization to data map |
| ConstructorItemTest.java | Added test coverage for active field default value, setter, and serialization |
| ConstructorVariationTest.java | Added test coverage for active field default value, setter, and serialization |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
constructorio-client/src/main/java/io/constructor/client/ConstructorItem.java
Outdated
Show resolved
Hide resolved
constructorio-client/src/main/java/io/constructor/client/ConstructorItem.java
Outdated
Show resolved
Hide resolved
constructorio-client/src/main/java/io/constructor/client/ConstructorVariation.java
Outdated
Show resolved
Hide resolved
constructorio-client/src/main/java/io/constructor/client/ConstructorVariation.java
Outdated
Show resolved
Hide resolved
…ructorItem.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ructorItem.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ructorVariation.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ructorVariation.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Mudaafi
approved these changes
Oct 22, 2025
Contributor
Mudaafi
left a comment
Mudaafi
left a comment
There was a problem hiding this comment.
Changes look good. There are a couple of failing tests due to the version numbers not matching the current version. Could you either update it in this PR or update it when creating the release?
esezen
deleted the
cdx-286-java-add-active-flag-support-for-constructoritem
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.