Automatically add 2 housing points when passing Spring Evals#366
Open
galenguyer wants to merge 2 commits intoComputerScienceHouse:developfrom
Open
Automatically add 2 housing points when passing Spring Evals#366galenguyer wants to merge 2 commits intoComputerScienceHouse:developfrom
galenguyer wants to merge 2 commits intoComputerScienceHouse:developfrom
Conversation
galenguyer
commented
Oct 1, 2022
If housing points are edited manually the cache may be out of date so we should make sure it isn't, as these are important to have correct before reading
mxmeinhold
reviewed
Oct 3, 2022
| if status == "Passed": | ||
| if ldap_is_intromember(account): | ||
| ldap_set_not_intro_member(account) | ||
| ldap_set_housingpoints(account, ldap_get_housingpoints(account) + 2) |
Contributor
There was a problem hiding this comment.
future: do we have handling of success/failure in ldap operations to give evals/rtps a list at the end of "here's all the results that need to be fixed"?
Member
Author
There was a problem hiding this comment.
I don't think we have that anywhere. I think a new issue is in order for that
Contributor
|
@galenguyer Do you want to fix the merge conflicts and we can re-review this? If not I'd love to look into it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.