Skip to content

[Onboarding Flow] Added database checks to the onboarding flow#34

Merged
MartinBraquet merged 59 commits into
CompassConnections:mainfrom
O-Bots:main
Mar 1, 2026
Merged

[Onboarding Flow] Added database checks to the onboarding flow#34
MartinBraquet merged 59 commits into
CompassConnections:mainfrom
O-Bots:main

Conversation

@O-Bots

@O-Bots O-Bots commented Feb 27, 2026

Copy link
Copy Markdown
Collaborator

Changes

  • Added database checks to the on-boarding flow test suite
  • Fixed Faker username generation so it follows compass guidelines (No symbols)

@vercel

vercel Bot commented Feb 27, 2026

Copy link
Copy Markdown

@O-Bots is attempting to deploy a commit to the Compass Team on Vercel.

A member of the Team first needs to authorize it.

@codecov

codecov Bot commented Feb 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
backend/shared/src/firebase-utils.ts 0.00% 2 Missing ⚠️
backend/shared/src/supabase/init.ts 0.00% 2 Missing ⚠️
common/src/supabase/utils.ts 0.00% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@MartinBraquet

Copy link
Copy Markdown
Member

Thanks! Could you check why the E2E tests failed?

[875](https://github.com/CompassConnections/Compass/actions/runs/22495983703/job/65170489004?pr=34#step:9:9876)
    ────────────────────────────────────────────────────────────────────────────────────────────────

    Retry #2 ───────────────────────────────────────────────────────────────────────────────────────

    Error: expect(received).toContain(expected) // indexOf

    Expected substring: "living room"
    Received string:    "university"

       at web/pages/profilePage.ts:233

      231 |     const textContent = await this.workAreaAboutSection.textContent()
      232 |     for (let i = 0; i < workArea.length; i++) {
    > 233 |       await expect(textContent?.toLowerCase()).toContain(workArea[i].toLowerCase())
          |                                                ^
      234 |     }
      235 |   }
      236 |
        at ProfilePage.verifyWorkArea (/home/runner/work/Compass/Compass/tests/e2e/web/pages/profilePage.ts:233:48)
        at /home/runner/work/Compass/Compass/tests/e2e/web/specs/onboardingFlow.spec.ts:96:5

    Error Context: test-results/web-specs-onboardingFlow-w-7ed2b-omplete-the-onboarding-flow-main-retry2/error-context.md

  1 failed

logs_58824779751.zip

@O-Bots

O-Bots commented Feb 27, 2026

Copy link
Copy Markdown
Collaborator Author

Just had a look at this, no idea what is happening ran the tests on my pc with nothing changed, all passed.

any ideas/possible solutions are welcomed

@MartinBraquet MartinBraquet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now! Thanks for adding the checks. I also added a few features at the same time, so the PR got bigger...
In the end, I can't really tell which change fixed the failing CI test. Must have been a really small bug somewhere in the pipeline, nothing major.

@MartinBraquet
MartinBraquet merged commit b18a6d7 into CompassConnections:main Mar 1, 2026
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants