Bump ms2rescore-rs and numpy dependencies#222
Closed
jonasscheid wants to merge 2 commits intoCompOmics:mainfrom
Closed
Bump ms2rescore-rs and numpy dependencies#222jonasscheid wants to merge 2 commits intoCompOmics:mainfrom
jonasscheid wants to merge 2 commits intoCompOmics:mainfrom
Conversation
Member
|
Hi Jonas, Thanks for the PR! I fixed the Numpy issue in #223 (for the v3.2 releases) and in #224 (for the v3.1 releases), so restricting Numpy won't be necessary. Is their a reason to restrict the ms2rescore-rs version? I had expected that pip/conda would always install the latest patch release, now that it is available? Best, |
Author
|
Hi Ralf, Thanks for the fast fix and release! That is all I was hoping for 🙏🏼 Indeed, not strictly needed to fix the version. Closing Best |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump dependencies to fix