Support for full PHPUnit public API#7
Merged
Naktibalda merged 3 commits intomasterfrom Aug 28, 2020
unknown repository
Merged
Conversation
Removed unnecessary comments in tests, replaced expectException with expectThrowable
…erts.php does and increase maintainability. Ordered tests according to their source.
8 tasks
Member
|
Cool, thank you for refactoring this part! Thank you! |
Author
|
@DavertMik The tests are failing because Codeception Module Asserts does not support various asserts from the public phpunit API, including the one that appears in that error, I presented a PR to add a large number of asserts that are not available so far, and since this repository uses that library, the CI server will fail until the changes are made merged first there. Thank you! |
Naktibalda
requested changes
Aug 28, 2020
Member
Naktibalda
left a comment
There was a problem hiding this comment.
Composer command in Github Actions fails because it takes too long.
@TavoNiievez Please make this change #8 in your branch.
Member
|
I will fix it myself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6
@Naktibalda Can you please take a look here and there.
It would be great if the changes were merged there to test through the CI here 👍 .