Birmingham | 26-ITP-Jan | Mohammed Omer | Sprint 1 | wireframe-sprint

[mo-omer]

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

Completed all tasks to match the guidelines given in the html and css templates for the wireframe layout
fixed footer to the bottom of the viewport based on previous reviewer feedback

improved code to prevent footer overlap bottom of articles
improved accessibility by assigning same header hierarchy to articles
adjusted image hight and width and fixed code error

[netlify]

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	e6556f6
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/6998e3b364f3b50008696cfa
😎 Deploy Preview	https://deploy-preview-1188--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[cjyuan]

• To better match the wireframe, can you align the height of the images in articles 2 and 3?

• The bottom border of articles 2 and 3 are covered by the footer. Can you prevent this from happening?

• According to https://validator.w3.org/, there are errors in your HTML code. Can you fix them?

• Can you improve the Lighthouse Accessibility score from 96 to 100?

[cjyuan]

Changes look good. Well done.

[cjyuan]

Please note that in CYF courses, the recommended way to inform the reviewer of your changes is to do both of the following:

• Reply to their feedback.
  • In the responses, clarify how each piece of feedback was addressed to demonstrate that you've carefully reviewed the suggestions.
    • You may find the suggestions in this PR Guide useful.
  • Your response may trigger a notification (depending on the reviewer's settings), helping ensure they’re aware of the updates you’ve made.
• Replace the "Reviewed" label by a "Needs review" label (which you have done -- great!)
  • Without this label, the reviewer would not know if your changes is ready to be reviewed.