-
-
Notifications
You must be signed in to change notification settings - Fork 36
London | 25-SDC-July | Mikiyas Gebremichael | Sprint 1 | Debugging - Hashtag Slowing Down the Browser #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,6 +15,12 @@ import {createHeading} from "../components/heading.mjs"; | |
| // Hashtag view: show all tweets containing this tag | ||
|
|
||
| function hashtagView(hashtag) { | ||
| if (state.currentHashtag !== hashtag) { | ||
| state.currentHashtag = hashtag; | ||
| state.hashtagBlooms = []; | ||
|
Comment on lines
+19
to
+20
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are there any drawbacks to setting these here? Is it set anywhere else?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thankyou @illicitonion , these values are only set inside the hashtagview and there is no conflict. but if i add more views later i should be careful about it. |
||
| apiService.getBloomsByHashtag(hashtag); | ||
| } | ||
|
|
||
| destroy(); | ||
|
|
||
| apiService.getBloomsByHashtag(hashtag); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you have to make this change? What did it fix? It seems unrelated to the bug being fixed here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i was getting an error related to compiling the python code and the debugger suggested using "-binary" to use a version that doesn't require compiling.