Construction Sign Model(s) & Textures

[MiffenKop]

Added top, bottom, and item models
Added construction textures

Summary by CodeRabbit

• New Features
  • Added a construction sign block with full rotational support (north/east/south/west) and upper/lower half variants for flexible placement.
  • Added corresponding 3D block and item visuals so the sign renders correctly in-world and in inventories.
  • Item display/transforms updated for consistent appearance in hand, GUI, ground, and other views.

[coderabbitai]

📝 Walkthrough

Walkthrough

Adds new construction_sign assets: a blockstate mapping for four facings and two halves, two block models (top/bottom) defining geometry and textures, and an item model with display transforms.

Changes

Cohort / File(s)	Summary
Blockstate src/main/resources/assets/minetale/blockstates/construction_sign.json	New blockstate file with variants for facing=(east,north,south,west) and half=(lower,upper), mapping to bottom/top models.
Block models src/main/resources/assets/minetale/models/block/furniture/construction_sign_bottom.json, src/main/resources/assets/minetale/models/block/furniture/construction_sign_top.json	New JSON block models specifying textures and multiple element prisms with rotations, per-face UVs, and particle texture references for bottom and top halves.
Item model src/main/resources/assets/minetale/models/item/furniture/construction_sign.json	New item model JSON with texture refs, multiple cuboid elements (rotations/mirroring), and detailed display transform configurations for various views.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

Poem

🐰 I dug a plan in moonlit sod,
A sign assembled, neat and broad,
Top and bottom, faces four,
I hop with pride and wink and roar—
Build on, build well, my wooden chord.

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main changes: adding construction sign model files (blockstate, bottom, top, and item models) and their associated textures.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection	✅ Passed	✅ No merge conflicts detected when merging into 1.21

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch models

---

No actionable comments were generated in the recent review. 🎉

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 4

🤖 Fix all issues with AI agents

In `@src/main/resources/assets/minetale/blockstates/construction_sign.json`:
- Around line 1-28: The facing variants for the construction_sign block lack y
rotations so the sign renders the same in all directions; update each variant
entry under "variants" to include a "y" rotation mapped from facing→y (north:0,
east:90, south:180, west:270) for both "construction_sign_bottom" and
"construction_sign_top" models (i.e., add "y":0/90/180/270 to the four lower and
four upper entries respectively, assuming the models face north by default).

In
`@src/main/resources/assets/minetale/models/item/furniture/construction_sign.json`:
- Line 10: The rotation.angle values in the elements use invalid numbers (e.g.,
4.21875); Minecraft requires rotation.angle to be a multiple of 22.5 within
[-45,45]. Find each JSON object with the "rotation" key (look for "rotation":
{"angle": ..., "axis": ..., "origin": ...} inside the elements array) and
replace the angle with a valid value (e.g., -45, -22.5, 0, 22.5, 45) — choose
the nearest acceptable multiple that preserves the intended orientation and
ensure the "axis" and "origin" fields remain unchanged.
- Around line 2-5: The item model's texture entries ("0" and "1") reference the
wrong namespace prefix "hytale:"; update both texture values in
construction_sign.json from "hytale:block/furniture/construction_sign" and
"hytale:block/furniture/construction_sign_edge" to use the "minetale:" namespace
so they match the block models and prevent missing texture rendering.
- Around line 186-188: The JSON contains a nonstandard display context
"on_shelf" (with its "translation" array) which Minecraft will ignore; either
remove the "on_shelf" block or replace it with one of the standard display
contexts (thirdperson_righthand, thirdperson_lefthand, firstperson_righthand,
firstperson_lefthand, gui, head, ground, fixed), or if you intentionally need
"on_shelf" add a matching custom display-context handler in the rendering/loader
code that recognizes "on_shelf" and applies the translation; locate the
"on_shelf" entry in the model JSON and either delete it or rename it to a
standard context (or implement the custom context mapping in your model loader).