Merged
Conversation
austincondiff
approved these changes
Jun 22, 2024
|
Hello, the previous issue is resolved, but now we have a new issue:when using Chinese or Japanese input method, input part of Chinese or Japanese, and then press the enter key, the text will be accidentally hidden. |
Contributor
Author
I'll look into this again, thank you for bringing it up |
6 tasks
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes marked text input for sequences longer than one marked character. Also ensures marked text works consistently with multiple cursors and adds testing for the marked text functionality.
Also:
TextView.markedTextAttributesproperty for modifying the marked text attributes if desired.Related Issues
Checklist
Screenshots
Screen.Recording.2024-06-22.at.12.45.56.AM.mov