Skip to content

DataList Component: Remove SelectableRowObject#1

Open
CodeDuchess wants to merge 1318 commits intoCodeDuchess:DataList-8423from
patternfly:v5
Open

DataList Component: Remove SelectableRowObject#1
CodeDuchess wants to merge 1318 commits intoCodeDuchess:DataList-8423from
patternfly:v5

Conversation

@CodeDuchess
Copy link
Owner

@CodeDuchess CodeDuchess commented Mar 16, 2023

Remove unneeded SelectableRowObject and replace with onSelectableRowChange
What: Closes patternfly#8423

The reviewers option to the right did not work for me.

@titani
@austin

@nicolethoen nicolethoen deleted the v5 branch June 5, 2023 19:13
wise-king-sullyman and others added 29 commits June 11, 2024 14:40
@wise-king-sullyman
chore(CI): Update stale action to not close things (#10526)
2ca9f9f
@renovate
chore(deps): update dependency lint-staged to ^15.2.6 (#10594)
d91ffa8 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@jonkoops
chore(deps): upgrade @typescript-eslint/ dependencies to the latest…
ed01da7 
… version (#10595)

Signed-off-by: Jon Koops <jonkoops@gmail.com>
@jonkoops
chore(deps): upgrade lerna to the latest version (#10593)
064c7b3 
Signed-off-by: Jon Koops <jonkoops@gmail.com>
@wise-king-sullyman
fix(build): get our custom TS transformers working again (#10477)
696957c 
* fix(build): get our custom TS transformers working again

* chore(deps): Update lock file

* Update lock file

* chore(deps): Update yarn lock
@renovate
chore(deps): update dependency sass to ^1.77.5 (#10597)
869575a 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@patternfly-build
chore(release): releasing packages [ci skip]
b1dd982 
 - eslint-plugin-patternfly-react@5.4.0-prerelease.4
 - @patternfly/react-charts@7.4.0-prerelease.12
 - @patternfly/react-code-editor@5.4.0-prerelease.18
 - @patternfly/react-core@5.4.0-prerelease.16
 - @patternfly/react-docs@6.4.0-prerelease.25
 - @patternfly/react-drag-drop@5.4.0-prerelease.17
 - @patternfly/react-icons@5.4.0-prerelease.6
 - @patternfly/react-integration@5.1.1-prerelease.33
 - demo-app-ts@5.1.1-prerelease.123
 - @patternfly/react-styles@5.4.0-prerelease.7
 - @patternfly/react-table@5.4.0-prerelease.17
 - @patternfly/react-templates@1.1.0-prerelease.16
 - @patternfly/react-tokens@5.4.0-prerelease.6
 - transformer-cjs-imports@4.79.4-prerelease.0
 - transformer-react-styles-esm-imports@1.0.1-prerelease.1
@renovate
chore(deps): update dependency ts-patch to ^3.2.0 (#10608)
53ca336 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@kmcfaul
feat(templates): toggle props & improvements (#10473)
315fc80 
* feat(templates): toggle props & improvements

* remove toggleContent from typeahead template

* update template names

* update tests

* added SimpleSelect tests

* fix yarnlock
@patternfly-build
chore(release): releasing packages [ci skip]
f7a6055 
 - @patternfly/react-docs@6.4.0-prerelease.26
 - @patternfly/react-templates@1.1.0-prerelease.17
@renovate
chore(deps): update dependency @patternfly/documentation-framework to…
c2a62e3 
… ^5.16.9 (#10599)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency lint-staged to ^15.2.7 (#10607)
cb10598 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency vite to ^5.3.1 (#10610)
c22798b 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@dominik-petrik
fix(CodeEditor) support Mac and PC shortcuts in example (#10472)
ca2c530
@renovate
chore(deps): update dependency lerna to ^8.1.5 (#10652)
f6de26a 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@wise-king-sullyman
chore(CI): Fix GH action to set stale issues status to needs triage (#…
78514fb 
…10615)

* chore(CI): Fix GH action to set stale issues status to needs triage

* chore(ci): Update stale action comments
@renovate
chore(deps): update dependency @testing-library/dom to ^10.2.0 (#10654)
f7fb762 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update yarn to v4.3.1 (#10653)
9002595 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
fix(deps): update dependency eslint-plugin-jsx-a11y to ^6.9.0 (#10633)
f808203 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency glob to ^10.4.2 (#10632)
244d115 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
fix(deps): update dependency eslint-plugin-react to ^7.34.3 (#10631)
e3c27c2 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update node.js to >=20.15.0 (#10627)
798610a 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency @patternfly/patternfly to v5.4.0-prere…
b11da96 
…lease.5 (#10609)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency sass to ^1.77.6 (#10628)
ca73bcd 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update typescript-eslint monorepo to ^7.14.1 (#10629)
82d4fbd 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update actions/add-to-project action to v1.0.2 (#10651)
1e31d2a 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency monaco-editor to ^0.50.0 (#10656)
6dfa5de 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency @types/node to ^20.14.9 (#10660)
0b33e4e 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency ts-patch to ^3.2.1 (#10668)
8adfca2 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot and others added 30 commits November 19, 2024 16:44
@renovate
chore(deps): update dependency vite to ^5.4.11 (#11240)
2db5abb 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update react monorepo (#11241)
d888b26 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@patternfly-build
chore(release): releasing packages [ci skip]
bef2bdc 
 - @patternfly/react-integration@5.4.5
 - demo-app-ts@5.4.14
@renovate
fix(deps): update dependency eslint-plugin-jsx-a11y to ^6.10.2 (#11244)
2dca61d 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update yarn to v4.5.1 (#11243)
4a7e07e 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
fix(deps): update dependency eslint-plugin-react to ^7.37.2 (#11245)
ccd7450 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
fix(deps): update dependency focus-trap to v7.6.2 (#11246)
abc266a 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency @eslint/compat to ^1.2.3 (#11248)
3c9ab50 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency @patternfly/documentation-framework to…
33c7c04 
… ^5.26.1 (#11250)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@tlabaj
fix(Toolbar): Fixed null exception in Toolbar filter V5 (#11223)
41e4429 
* fix(Toolbar): Fixed null exception in Toolbar filter V5

* Updates form review comments

* fix yarn
@patternfly-build
chore(release): releasing packages [ci skip]
0f3ece1 
 - eslint-plugin-patternfly-react@5.4.4
 - @patternfly/react-code-editor@5.4.13
 - @patternfly/react-core@5.4.10
 - @patternfly/react-docs@6.4.18
 - @patternfly/react-drag-drop@5.4.10
 - demo-app-ts@5.4.15
 - @patternfly/react-table@5.4.11
 - @patternfly/react-templates@1.1.11
@renovate
chore(deps): update dependency @testing-library/jest-dom to ^6.6.3 (#…
75638d7 
…11251)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency eslint-plugin-testing-library to ^6.5.0 (
d0af1c8 
#11254)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency globals to ^15.12.0 (#11255)
a7657ef 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency rollup to ^4.27.3 (#11257)
ceb5d0e 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency sass to ^1.81.0 (#11258)
af540d5 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@adamviktora
feat(V5 Select/Dropdown/MenuContainer): arrow key handling to focus i…
623da5e 
…tems (#11249)

* feat(Select): default arrow key handling to focus items

* feat(Dropdown): default arrow key handling to focus items

* feat(MenuContainer): default arrow key handling to focus items

* fix: invoke callback only when toggle is focused and menu opened

* fix: query selector, refactor common functionality

* feat: use general onToggleKeydown instead of onToggleArrowKeydown

* refactor(onToggleArrowKeydownDefault): don't use :has() selector

* fix: remove isTypeahead prop in favor of variant

* feat(MenuContainer): update to include V6 changes
@patternfly-build
chore(release): releasing packages [ci skip]
2c6037e 
 - @patternfly/react-code-editor@5.4.14
 - @patternfly/react-core@5.4.11
 - @patternfly/react-docs@6.4.19
 - @patternfly/react-drag-drop@5.4.11
 - demo-app-ts@5.4.16
 - @patternfly/react-table@5.4.12
 - @patternfly/react-templates@1.1.12
@mfrances17
fix(DualListSelector): resolve tsc type issues (#11346)
7c157a0
@patternfly-build
chore(release): releasing packages [ci skip]
0eb8f37 
 - @patternfly/react-code-editor@5.4.15
 - @patternfly/react-core@5.4.12
 - @patternfly/react-docs@6.4.20
 - @patternfly/react-drag-drop@5.4.12
 - demo-app-ts@5.4.17
 - @patternfly/react-table@5.4.13
 - @patternfly/react-templates@1.1.13
@dlabrecq
fix(charts): fix Victory 37.3.4 issues (#11355)
a50c281 
#11354
@patternfly-build
chore(release): releasing packages [ci skip]
00532d7 
 - @patternfly/react-charts@7.4.8
 - @patternfly/react-docs@6.4.21
@adamviktora
refactor(misc): change imports from '@patternfly/react-core' to direc…
067ed1d 
…t imports (V5) (#11375)

* refactor(misc): change imports from '@patternfly/react-core' to direct imports

- this change reduces size of CSS that is imported

* test(CheckboxSelect): update snapshot
@patternfly-build
chore(release): releasing packages [ci skip]
97dd901 
 - @patternfly/react-code-editor@5.4.16
 - @patternfly/react-docs@6.4.22
 - @patternfly/react-drag-drop@5.4.13
 - @patternfly/react-integration@5.4.6
 - demo-app-ts@5.4.18
 - @patternfly/react-table@5.4.14
 - @patternfly/react-templates@1.1.14
@dlabrecq
fix(charts) - update Victory and CodeSandbox examples (#11458)
57508ec
@patternfly-build
chore(release): releasing packages [ci skip]
8887669 
 - @patternfly/react-charts@7.4.9
 - @patternfly/react-docs@6.4.23
@thatblindgeye
fix(FileUpload): hid input of type file from AT (v5) (#11437)
754b6a7 
* fix(FileUpload): hid input of type file from AT (v5)

* Updated snapshots
@patternfly-build
chore(release): releasing packages [ci skip]
c132f12 
 - @patternfly/react-code-editor@5.4.17
 - @patternfly/react-core@5.4.13
 - @patternfly/react-docs@6.4.24
 - @patternfly/react-drag-drop@5.4.14
 - demo-app-ts@5.4.19
 - @patternfly/react-table@5.4.15
 - @patternfly/react-templates@1.1.15
@kmcfaul
fix(DescriptionList): V5 - allow help text button popover to open via…
119e796 
… keyboard (#11547)

* fix(DescriptionList): V5 - allow help text button popover to open via keyboard

* clean up branch switch
@patternfly-build
chore(release): releasing packages [ci skip]
2aa38ef 
 - @patternfly/react-code-editor@5.4.18
 - @patternfly/react-core@5.4.14
 - @patternfly/react-docs@6.4.25
 - @patternfly/react-drag-drop@5.4.15
 - demo-app-ts@5.4.20
 - @patternfly/react-table@5.4.16
 - @patternfly/react-templates@1.1.16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.