fix(pinia-orm): Model original data is overwritten by different namspace models with same ID#1954
Merged
CodeDredd merged 2 commits intoCodeDredd:mainfrom Nov 25, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1954 +/- ##
=======================================
Coverage 99.48% 99.48%
=======================================
Files 86 86
Lines 3123 3124 +1
Branches 526 526
=======================================
+ Hits 3107 3108 +1
Misses 14 14
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Owner
|
@petrmifek Nice PR. 👍 Only linting is missing and i can merge it 😉 |
Contributor
Author
|
Ah, missed that, sorry. Would this work? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves #1953
📚 Description
The
originalstatic property in the Model class stores original states using only the model's ID as the key, causing different model types to overwrite each other's original states when they share the same ID.This PR is separating/namespacing the original states by model entity