Refactor to introduce the snapshot sync#1916
Merged
mergify[bot] merged 9 commits intoCodeChain-io:masterfrom Dec 7, 2019
Merged
Refactor to introduce the snapshot sync#1916mergify[bot] merged 9 commits intoCodeChain-io:masterfrom
mergify[bot] merged 9 commits intoCodeChain-io:masterfrom
Conversation
Closed
remagpie
previously approved these changes
Dec 5, 2019
majecty
previously approved these changes
Dec 6, 2019
sgkim126
requested changes
Dec 6, 2019
Contributor
sgkim126
left a comment
sgkim126
left a comment
There was a problem hiding this comment.
Please resolve conflicts.
`block_number_if_term_changed` was returning the current block number if the term changed, which could be calculated in the outer scope.
foriequal0
force-pushed
the
feature/era-refactor
branch
from
c8c95f7 to
c66fb4b
Compare
Closed
sgkim126
approved these changes
Dec 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is cherry-picked refactor commits while working on this PR #1910
You might have seen those changes before. This shouldn't change the behavior drastically.
erato CommonParams #1893 Adderato CommonParamson_close_block, take #2 #1896 Refactoron_close_block, take Add JSON RPC ping endpoint #2