Cherry-pick] Set finalized_view to None when restoring in the Commit step #1866#1868
Closed
foriequal0 wants to merge 1 commit intoCodeChain-io:masterfrom
Closed
Cherry-pick] Set finalized_view to None when restoring in the Commit step #1866#1868foriequal0 wants to merge 1 commit intoCodeChain-io:masterfrom
foriequal0 wants to merge 1 commit intoCodeChain-io:masterfrom
Conversation
In the Tendermint restoring process, if the backup state is the Commit step, CodeChain set the step to the Precommit step and handles the votes. The purpose of the behavior is that calling functions that are called when enters the Commit state. After we introduce the `finalized_view_of_current_block` variable, the variable should be changed to `None` when CodeChain sets the state to Precommit in the restoring process.
sgkim126
approved these changes
Nov 17, 2019
|
@foriequal0 I added a new PR that fixes the same problem. Could you check it? |
Contributor
Author
|
We decided to drop and revert this from master & 2.2.1 and proceed the release with the new patch from @majecty |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1866 was a hotfix so it should be backported(?) to the master.