Enable all grandchild of the best block to become a best proposal block#1813
Merged
majecty merged 1 commit intoCodeChain-io:masterfrom Oct 15, 2019
Merged
Enable all grandchild of the best block to become a best proposal block#1813majecty merged 1 commit intoCodeChain-io:masterfrom
majecty merged 1 commit intoCodeChain-io:masterfrom
Conversation
Before this commit, only the child of the best block and the child of the best proposal block could be a new best proposal block. A block that is a grandchild of the best block but not the child of the best proposal block should be able to become a best proposal block. After this commit, CodeChain checks whether a new block is the best block's child or grandchild.
Contributor
|
It seems to be very ad-hoc. Is there any chance to receive grand-grand children? |
Author
|
@foriequal0 Here is an example.
|
foriequal0
approved these changes
Oct 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this commit, only the child of the best block and the child of the best proposal block could be a new best proposal block. A block that is a grandchild of the best block but not the child of the best proposal block should be able to become a best proposal block.
After this commit, CodeChain checks whether a new block is the best block's child or grandchild.