Conversation
Contributor
Author
|
I'm still working on it. There are still things to be fixed. Most of them are error types and tests related. |
joojis
force-pushed
the
remove-order
branch
from
fc488fa to
0b5ec26
Compare
Contributor
Author
|
I'm resolving conflicts |
joojis
force-pushed
the
remove-order
branch
from
3e29026 to
efa46ac
Compare
joojis
force-pushed
the
remove-order
branch
from
efa46ac to
e63fad9
Compare
majecty
previously approved these changes
Sep 23, 2019
joojis
force-pushed
the
remove-order
branch
from
e63fad9 to
67dadb1
Compare
joojis
force-pushed
the
remove-order
branch
from
67dadb1 to
fea01eb
Compare
Contributor
Author
|
@majecty Sorry, I dismissed your review while resolving a build warning. |
Contributor
Author
|
I will let you know when build passes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It resolves #1776