Fix a memory leak in header downloader's downloaded#1749
Merged
majecty merged 2 commits intoCodeChain-io:masterfrom Aug 30, 2019
Merged
Fix a memory leak in header downloader's downloaded#1749majecty merged 2 commits intoCodeChain-io:masterfrom
majecty merged 2 commits intoCodeChain-io:masterfrom
Conversation
remagpie
previously approved these changes
Aug 28, 2019
HoOngEe
requested changes
Aug 28, 2019
Contributor
HoOngEe
left a comment
HoOngEe
left a comment
There was a problem hiding this comment.
Please add downloaded.shrink_to_fit(); in the below.
The header downloader has two queues. The first one is the downloaded queue, and the second one is the "queued" queue. If a header is downloaded, downloader enqueues the header to the downloaded queue. When starting to import the header, the downloader removes the header from the downloaded queue and enqueues the header to the "queued" queue. When the importing is done, the downloader removes the header from the "queued" queue. However, if a header(let's call it A) is downloaded and is imported already, A is not removed from the downloaded queue forever. This commit removes A from the downloaded header.
majecty
force-pushed
the
f/memory-leak-downloader
branch
from
84bf276 to
28f4c38
Compare
Author
|
@HoOngEe I added it. |
HoOngEe
approved these changes
Aug 28, 2019
Author
|
@remagpie Please approve it! |
remagpie
approved these changes
Aug 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The header downloader has two queues. The first one is the downloaded
queue, and the second one is the "queued" queue. If a header is
downloaded, downloader enqueues the header to the downloaded
queue. When starting to import the header, the downloader removes the
header from the downloaded queue and enqueues the header to the
"queued" queue. When the importing is done, the downloader removes the
header from the "queued" queue.
However, if a header(let's call it A) is downloaded and is imported
already, A is not removed from the downloaded queue forever. This
commit removes A from the downloaded header.