Implement reportDoubleVote custom action by HoOngEe · Pull Request #1640 · CodeChain-io/codechain

HoOngEe · 2019-06-18T12:22:45Z

No description provided.

majecty · 2019-07-02T00:37:57Z

@HoOngEe What is the current status of this PR?
Do you need someone to review it? Or something is not done yet?

HoOngEe · 2019-07-02T02:34:56Z

@majecty I need someone to review it.

majecty · 2019-07-02T02:48:09Z

@HoOngEe Please fix the conflicts.
After fixing it, @foriequal0 and I will review this PR.

HoOngEe · 2019-07-02T05:33:02Z

@majecty I resolved the conflicts

majecty

What happened to the delegated CCS of the banned validator.

majecty · 2019-07-03T09:04:52Z

core/src/consensus/stake/actions.rs

The signer may be different from the message's signer. We should get the prev term's signers.

majecty · 2019-07-03T09:09:37Z

core/src/consensus/stake/mod.rs

Why give CCC as a deposit?
Any reason for this? How about give CCC directly to the informant?

Yes you are right, I misread the spec

HoOngEe · 2019-07-05T10:54:22Z

@foriequal0 I remember you mentioned about the expected compile error

^^^^^^ expected trait cstate::ActionHandler, found struct `consensus::stake::Stake`

at the line
But I could not recall the solution.

HoOngEe · 2019-07-05T10:57:32Z

I have almost done. But I would better to change the error handling policy on "Cannot get validators from the parent state" part.

HoOngEe · 2019-07-08T08:55:02Z

Now I'll change the error types which would be returned by the ActionHandler::verify method.

majecty

LGTM

core/src/consensus/stake/actions.rs

core/src/consensus/stake/mod.rs

core/src/consensus/mod.rs

core/src/consensus/validator_set/mod.rs

majecty · 2019-07-16T02:58:47Z

@foriequal0 Could you check this PR again?

core/src/consensus/stake/actions.rs

core/src/consensus/stake/mod.rs

core/src/consensus/tendermint/message.rs

core/src/consensus/stake/actions.rs

foriequal0 · 2019-07-23T06:30:39Z

core/src/consensus/stake/actions.rs

(Question) Do we have a chance to have the same signer with two different signer indexes?

So sharp. I'll change the code like this:
First compare signer_idx1 and signer_idx2. If they are different, invoke an error.
Then, I'll get signer public key without collecting all pubkeys in vector.

core/src/consensus/stake/actions.rs

core/src/consensus/stake/mod.rs

core/src/consensus/stake/actions.rs

HoOngEe · 2019-07-25T04:47:28Z

I now need to reject reportDoubleVote for already banned account.

majecty · 2019-07-26T06:10:27Z

core/src/consensus/stake/mod.rs

Let's remove #[allow(dead_code)]

I removed it.

majecty

LGTM

foriequal0 · 2019-07-29T17:15:33Z

core/src/consensus/stake/actions.rs

+    pub fn verify(
+        &self,
+        current_params: &CommonParams,
+        client: Option<Arc<ConsensusClient>>,


You could've accepted just &ConsensusClient. Anyway, We'll ship it now and fix it later.

core/src/consensus/stake/actions.rs

HoOngEe force-pushed the feature/report-double-vote branch 3 times, most recently from 6e77495 to 2ac4e10 Compare June 20, 2019 05:32

HoOngEe changed the title ~~[WIP] Implement report_double_vote custom action~~ Implement report_double_vote custom action Jun 20, 2019

HoOngEe changed the title ~~Implement report_double_vote custom action~~ Implement reportDoubleVote custom action Jun 20, 2019

majecty requested review from foriequal0 and majecty July 2, 2019 02:47

HoOngEe force-pushed the feature/report-double-vote branch 2 times, most recently from 9ec2703 to e375c1a Compare July 2, 2019 04:59

majecty requested changes Jul 3, 2019

View reviewed changes

HoOngEe force-pushed the feature/report-double-vote branch 2 times, most recently from 2f4e11e to 73fae8f Compare July 5, 2019 10:51

HoOngEe force-pushed the feature/report-double-vote branch 3 times, most recently from 906d18e to 1ae58ea Compare July 8, 2019 07:28

majecty previously approved these changes Jul 9, 2019

View reviewed changes

foriequal0 requested changes Jul 10, 2019

View reviewed changes

core/src/consensus/stake/actions.rs Outdated Show resolved Hide resolved

core/src/consensus/stake/mod.rs Outdated Show resolved Hide resolved

core/src/consensus/mod.rs Outdated Show resolved Hide resolved

core/src/consensus/validator_set/mod.rs Outdated Show resolved Hide resolved

HoOngEe dismissed majecty’s stale review via 0224395 July 10, 2019 09:31

HoOngEe force-pushed the feature/report-double-vote branch from edd8f8e to 0224395 Compare July 10, 2019 09:31

majecty previously approved these changes Jul 16, 2019

View reviewed changes

foriequal0 requested changes Jul 16, 2019

View reviewed changes

core/src/consensus/stake/actions.rs Outdated Show resolved Hide resolved

core/src/consensus/stake/mod.rs Outdated Show resolved Hide resolved

CodeChain-io deleted a comment from foriequal0 Jul 16, 2019

HoOngEe force-pushed the feature/report-double-vote branch from d0fface to 5ccd56f Compare July 23, 2019 05:38

foriequal0 requested changes Jul 23, 2019

View reviewed changes

HoOngEe force-pushed the feature/report-double-vote branch 7 times, most recently from 34085c5 to b319f60 Compare July 24, 2019 12:09

HoOngEe force-pushed the feature/report-double-vote branch 2 times, most recently from 16eb793 to d6492aa Compare July 25, 2019 10:10

majecty reviewed Jul 26, 2019

View reviewed changes

HoOngEe force-pushed the feature/report-double-vote branch 4 times, most recently from a62db10 to cadfeea Compare July 26, 2019 07:55

majecty previously approved these changes Jul 29, 2019

View reviewed changes

HoOngEe dismissed majecty’s stale review via 3a34328 July 29, 2019 08:18

HoOngEe force-pushed the feature/report-double-vote branch from cadfeea to 3a34328 Compare July 29, 2019 08:18

HoOngEe added 3 commits July 29, 2019 17:18

implement report_double_vote custom action

b9c59cc

Fix unit tests by adding type annotation

1d06b13

Add test cases for verification of reportDoubleVote

848fa8a

HoOngEe force-pushed the feature/report-double-vote branch from 3a34328 to 848fa8a Compare July 29, 2019 08:19

majecty approved these changes Jul 29, 2019

View reviewed changes

foriequal0 approved these changes Jul 29, 2019

View reviewed changes

mergify bot and others added 2 commits July 29, 2019 17:23

Merge branch 'master' into feature/report-double-vote

1b25083

Merge branch 'master' into feature/report-double-vote

a01031e

majecty merged commit 9a88541 into CodeChain-io:master Jul 30, 2019

HoOngEe deleted the feature/report-double-vote branch July 30, 2019 06:17

Conversation

HoOngEe commented Jun 18, 2019

Uh oh!

majecty commented Jul 2, 2019

Uh oh!

HoOngEe commented Jul 2, 2019

Uh oh!

majecty commented Jul 2, 2019

Uh oh!

HoOngEe commented Jul 2, 2019

Uh oh!

majecty left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HoOngEe commented Jul 5, 2019

Uh oh!

HoOngEe commented Jul 5, 2019

Uh oh!

HoOngEe commented Jul 8, 2019

Uh oh!

majecty left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

majecty commented Jul 16, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

HoOngEe commented Jul 25, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

majecty left a comment

Choose a reason for hiding this comment

Uh oh!

foriequal0 Jul 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

foriequal0 Jul 29, 2019 •

edited

Loading