Change the stakeholders in solo e2e tests scheme#1554
Merged
mergify[bot] merged 1 commit intoCodeChain-io:masterfrom May 23, 2019
sgkim126:const
Merged
Change the stakeholders in solo e2e tests scheme#1554mergify[bot] merged 1 commit intoCodeChain-io:masterfrom sgkim126:const
mergify[bot] merged 1 commit intoCodeChain-io:masterfrom
sgkim126:const
Conversation
Currently, the stake rates of faucet:Alice:Bob is 7:2:1. This rate makes hard to test the real case because the faucet account has more than 2/3 and others cannot reach half. This commit changes the rate to Alice:Bob:Carol:Dave to 4:3:2:1.
Merged
foriequal0
approved these changes
May 23, 2019
Contributor
foriequal0
left a comment
foriequal0
left a comment
There was a problem hiding this comment.
LGTM. Why don't you change Tendermint scheme too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the stake rates of Alice:Bob:Carol is 7:2:1.
This rate makes hard to test the real case because Alice has more than
2/3 and others cannot reach half.
This commit changes the rate to Alice:Bob:Carol:Dave to 4:3:2:1.