Use the child of the best header to verify transactions#1545
Merged
mergify[bot] merged 1 commit intoCodeChain-io:masterfrom May 20, 2019
sgkim126:best
Merged
Use the child of the best header to verify transactions#1545mergify[bot] merged 1 commit intoCodeChain-io:masterfrom sgkim126:best
mergify[bot] merged 1 commit intoCodeChain-io:masterfrom
sgkim126:best
Conversation
In the previous implementation, the transaction expired after the parent block is added in the pool and rejected during execution. This patch makes mempool reject the transaction. So the expriation e2e tests are adjusted.
Contributor
Author
|
@majecty Please review it again. I fixed e2e tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, it does not matter because the header is used to get the
CommonParamsthat doesn't depend on the block number. But the next patch will make it changeable.