Add base-path option to the codechin cli arguments#1499
Add base-path option to the codechin cli arguments#1499mergify[bot] merged 3 commits intoCodeChain-io:masterfrom
Conversation
de0bf6d to
32bb133
Compare
32bb133 to
3c283f5
Compare
| base_path = "." | ||
| chain = "mainnet" | ||
|
|
||
|
|
There was a problem hiding this comment.
You don't need this change.
There was a problem hiding this comment.
Without this change, the code in the line https://github.com/CodeChain-io/codechain/pull/1499/files/3c283f526dfb43ca1261fa5a77f090e2626b41c7#diff-22a0b3dcef5d27fab89655ebdb330967R257 could be a cause of panic.
Do I need to remove this change and use unwrap_or for the line mentioned above?
There was a problem hiding this comment.
Why does it panic when you remove an empty line?
There was a problem hiding this comment.
Oh I'm sorry I misunderstood that you mentioned about the +base_path = "." change.
|
Hi @majecty @foriequal0, I have a question about the behavior of a relative path. |
|
I'm not familiar with the setting two paths in CLI. |
3c283f5 to
eebaf41
Compare
sgkim126
left a comment
There was a problem hiding this comment.
I think it's better to merge it for now and implement a sandbox correctly in the future.
Let's merge it.
Now It's possible to specify
base-pathon which the keys and db directory will be created when running codechain. But there already are optionsdb-pathandkeys-path.The rule relating to
db-path,keys-pathandbase-pathis like following:db-pathandkeys-pathhave higher priority thanbase-pathso ifboth
db-pathandkeys-pathare set,base-pathbecomes meaningless.it closes #236