Skip to content

Add stake actions for revoke, self nominate, jail, ban#1445

Merged
mergify[bot] merged 6 commits intoCodeChain-io:masterfrom
foriequal0:feature/revoke
May 30, 2019
Merged

Add stake actions for revoke, self nominate, jail, ban#1445
mergify[bot] merged 6 commits intoCodeChain-io:masterfrom
foriequal0:feature/revoke

Conversation

@foriequal0
Copy link
Contributor

@foriequal0 foriequal0 commented Apr 5, 2019 •
edited
Loading

Depends on: #1559

@foriequal0
Copy link
Contributor Author

foriequal0 commented Apr 5, 2019 •
edited
Loading

It'll be ready after adding some tests

@foriequal0 foriequal0 force-pushed the feature/revoke branch 2 times, most recently from ff75419 to 4ef7366 Compare April 8, 2019 01:57
@foriequal0 foriequal0 requested a review from sgkim126 April 8, 2019 01:58
@foriequal0 foriequal0 changed the title [WIP] Stake revocation Stake revocation Apr 8, 2019
@sgkim126 sgkim126 added the do-not-merge Do not merge (for mergify.io) label Apr 8, 2019
sgkim126
sgkim126 requested changes Apr 8, 2019
View reviewed changes
@sgkim126
Copy link
Contributor

sgkim126 commented Apr 8, 2019

How about splitting 38a981b into refactoring the apply function to take the current block timestamp and implementing revocation?
I want to merge refactoring but not to merge the revocation for now.

@foriequal0
Copy link
Contributor Author

foriequal0 commented Apr 8, 2019

I separated out a patch that State::apply to take the current block timestamp into #1455
#1455 This is going to be merged first.

@foriequal0 foriequal0 force-pushed the feature/revoke branch 11 times, most recently from 943e9d1 to 2f04c71 Compare April 15, 2019 09:49
@foriequal0 foriequal0 changed the title Stake revocation Add StakeAction::Revoke, StakeAction::SelfNominate May 21, 2019
@foriequal0 foriequal0 changed the title Add StakeAction::Revoke, StakeAction::SelfNominate [WIP] Add StakeAction::Revoke, StakeAction::SelfNominate May 21, 2019
@foriequal0
Copy link
Contributor Author

foriequal0 commented May 21, 2019

Note that this PR is largely changed after a redesign.
This PR should be rebased upon @sgkim126 's PR that saves the block number of the last term in the state.

@foriequal0 foriequal0 mentioned this pull request May 21, 2019
Closed
@sgkim126
Copy link
Contributor

sgkim126 commented May 29, 2019

@foriequal0
When will it be done?

@sgkim126 sgkim126 mentioned this pull request May 29, 2019
Merged
@foriequal0 foriequal0 force-pushed the feature/revoke branch 2 times, most recently from 1f1f132 to 468175f Compare May 29, 2019 16:57
@foriequal0 foriequal0 changed the title [WIP] Add StakeAction::Revoke, StakeAction::SelfNominate Add stake actions for revoke, self nominate, jail, ban May 29, 2019
@foriequal0 foriequal0 force-pushed the feature/revoke branch 2 times, most recently from 922d7b7 to 1f22687 Compare May 30, 2019 01:29
sgkim126
sgkim126 reviewed May 30, 2019
View reviewed changes
sgkim126
sgkim126 reviewed May 30, 2019
View reviewed changes
sgkim126
sgkim126 reviewed May 30, 2019
View reviewed changes
foriequal0 added 3 commits May 30, 2019 15:35
@foriequal0
Cleanup stake tests
0277510 
- Replace assertions with unwrap that are not a concern of a test.
- Reorder assertions by states
- Add reasons to assertions
@foriequal0
Implement delegation subtract
e6002f3
@foriequal0
Implement revoke
ae77dcc
@foriequal0 foriequal0 force-pushed the feature/revoke branch 4 times, most recently from 89e7b4a to f77eff1 Compare May 30, 2019 07:13
sgkim126
sgkim126 requested changes May 30, 2019
View reviewed changes
sgkim126
sgkim126 requested changes May 30, 2019
View reviewed changes
sgkim126
sgkim126 reviewed May 30, 2019
View reviewed changes
@sgkim126 sgkim126 removed the do-not-merge Do not merge (for mergify.io) label May 30, 2019
@mergify mergify bot merged commit e20f1bb into CodeChain-io:master May 30, 2019
@sgkim126 sgkim126 mentioned this pull request Jun 14, 2019
Closed
@foriequal0 foriequal0 deleted the feature/revoke branch June 24, 2019 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sgkim126 sgkim126 sgkim126 approved these changes

Assignees

No one assigned

Labels

transaction

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@foriequal0 @sgkim126