bazel build is broken on v1.3.0

[anonrig]

Upgrading to 1.3.0 on a bazel build breaks. Ref: cloudflare/workerd#5324

[fhanau]

Note that this applies when --incompatible_disallow_empty_glob is set – this is the default starting with Bazel 8, and seems to be set manually in the .bazelrc, I wonder why CI didn't catch it.

[not-matthias]

Hey, thanks for the bug report!

The root cause seems to be that http_archive doesn't include git submodules which we are using for the instrument-hooks dependency. You can replace the http_archive call in your build/google-benchmark/MODULE.bazel with the following:

module(name = "workerd-google-benchmark")

bazel_dep(name = "bazel_skylib", version = "1.8.1")
bazel_dep(name = "platforms", version = "1.0.0")
bazel_dep(name = "rules_cc", version = "0.2.8")

git_repository = use_repo_rule("@bazel_tools//tools/build_defs/repo:git.bzl", "git_repository")
git_repository(
    name = "codspeed",
    commit = "2b6afb971742dfc003aa350a6aae4efc33f933f4",
    remote = "https://github.com/CodSpeedHQ/codspeed-cpp",
    recursive_init_submodules = True
)

And this will already work with v1.3.0.

Let me know if this approach works for you or if there's a better way to do it!

[anonrig]

@not-matthias can you also review #23? since we already float this patch on top of codspeed-cpp. without it, our build will not work.