Remove diagnostics from dscim#60
Merged
Merged
Conversation
This reverts commit 9f82824.
Codecov Report
@@ Coverage Diff @@
## dscim-v0.4.0 #60 +/- ##
=================================================
+ Coverage 29.00% 43.24% +14.24%
=================================================
Files 30 18 -12
Lines 2551 1711 -840
=================================================
Hits 740 740
+ Misses 1811 971 -840 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
davidrzhdu
approved these changes
Jan 11, 2023
kemccusker
reviewed
Jan 17, 2023
| ## [Unreleased] | ||
| - Remove diagnostics module. ([PR #60](https://github.com/ClimateImpactLab/dscim/pull/60, [@JMGilbert](https://github.com/JMGilbert)) | ||
| - Remove old/unnecessary files. ([PR #57](https://github.com/ClimateImpactLab/dscim/pull/57), [@JMGilbert](https://github.com/JMGilbert)) | ||
|
|
Member
There was a problem hiding this comment.
does it make sense to add mention of pinning the two packages due to the float issue?
Contributor
Author
There was a problem hiding this comment.
I'm working to unpin the packages by messing with the code, so I'm hoping that won't be necessary. But I will definitely mention that if I can't figure this out.
kemccusker
approved these changes
Jan 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.