Remove unused time_trend extrapolation cruft from utils.model_outputs(), update docstrs#53
Conversation
Remove code relating to "time_trends" extrapolation -- which apparently has an incomplete/incorrect implementation here.
Removes additional cruft relating to crufty "time_trends" extrapolation.
|
Looks like CI tests are failing because they're using the old model_outputs() signature. I think I can fix this. |
brews
changed the title
|
Okay, things are working now. I think this is set for review. |
brews
changed the title
| global_c : xr.DataArray | ||
| Array with global consumption extrapolated to 2300. This is only used | ||
| when ``extrapolation_type`` is ``global_c_ratio``. | ||
| fix_global_c : int |
There was a problem hiding this comment.
fix_global_c is relevant to the extrapolation method that we do use. Is it not used in the function?
There was a problem hiding this comment.
@kemccusker There literally was no fix_global_c argument to this function, thus me removing it from the docstr. It was referencing something that wasn't there...
However, there is a fix_global_c variable here.
Codecov Report
@@ Coverage Diff @@
## dscim-v0.4.0 #53 +/- ##
================================================
- Coverage 55.87% 55.81% -0.06%
================================================
Files 17 17
Lines 1865 1856 -9
================================================
- Hits 1042 1036 -6
+ Misses 823 820 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
3 participants
Removes code relating to "time_trend" option to "extrapolation" in
dscim.utils.utils.model_outputs().Code is removed along with unused internal variables. Because they are unused, the following parameters are also removed from
dscim.utils.utils.model_outputs():extrap_formulaextrap_yearyear_end_predbase_yearBeware this will break code that tries to pass in these parameters.
Close #15