Skip to content

Add naive list of package dependencies to pyproject.toml#123

Merged
kemccusker merged 7 commits intomainfrom
pkg_reqs
Aug 10, 2023
Merged

Add naive list of package dependencies to pyproject.toml#123
kemccusker merged 7 commits intomainfrom
pkg_reqs

Conversation

@brews
Copy link
Copy Markdown
Member

@brews brews commented Aug 4, 2023

This PR adds a list of package dependencies so people have an idea of what's required to run things.

Basically, this takes the packages in requirement.txt and puts them into pyproject.toml, without version pins.

I have a feeling that some of these are not really hard required dependencies. Some might be optional, so we might want to tweak these a bit and make some optional dependencies or "features". Like a "viz" section that installs stuff required to do graphics and plots -- then we can make those packages optional. "io" might be another good one because it looks like there are a couple heavy packages for reading and writing different file formats and I'm not sure if these are always required. Anyways, that might be a task for another PR.

Close #102

@brews brews self-assigned this Aug 4, 2023
@brews brews requested a review from kemccusker August 4, 2023 17:29
@brews brews marked this pull request as ready for review August 4, 2023 17:29
@brews
Copy link
Copy Markdown
Member Author

brews commented Aug 4, 2023

Feel free to merge this if it reviews good.

I'm not sure if we know enough to move some of these to an optional dependency section. Happy to do that here if reviewers think we can do that and can give me some direction.

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 4, 2023

Codecov Report

Merging #123 (e7cc015) into main (b24b214) will not change coverage.
Report is 4 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #123   +/-   ##
=======================================
  Coverage   65.27%   65.27%           
=======================================
  Files          17       17           
  Lines        1846     1846           
=======================================
  Hits         1205     1205           
  Misses        641      641           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Copy Markdown
Member Author

@brews brews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Collapse dask requirements

Copy link
Copy Markdown
Member

@kemccusker kemccusker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense and looks good to me. There might be the opportunity for optional deps, especially if dscim is only used for running from damage function coefs, rather than from the spatial damage inputs. This should be a later PR.

@kemccusker kemccusker merged commit 84cd787 into main Aug 10, 2023
@kemccusker kemccusker deleted the pkg_reqs branch August 10, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Put dscim dependencies in pyproject.toml

2 participants