Fill laravel-ingest package fields; enforce field-source mapping in agent#8
Conversation
Agent-Logs-Url: https://github.com/ChrisThompsonTLDR/agentic-programming/sessions/0f76ba83-794f-4d3a-8061-3aa45d3abf51 Co-authored-by: ChrisThompsonTLDR <348801+ChrisThompsonTLDR@users.noreply.github.com>
…dance Agent-Logs-Url: https://github.com/ChrisThompsonTLDR/agentic-programming/sessions/0c7c3dc5-1e26-471c-9c22-2ef2af824378 Co-authored-by: ChrisThompsonTLDR <348801+ChrisThompsonTLDR@users.noreply.github.com>
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
WalkthroughReplaces ad-hoc data-gathering steps in the Laravel package research agent/skill with explicit field-to-source mappings and field-resolution rules (must attempt every field), and adds a new detailed documentation page for the Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 69b28dbb06
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| | Field | Source | | ||
| |-------|--------| | ||
| | `author` | Packagist (`packagist.org/packages/<vendor>/<package>.json` → `authors[0].name`) | |
There was a problem hiding this comment.
The new mapping points author to authors[0].name, but Packagist package JSON does not expose a top-level authors field for this endpoint; author data is nested under version objects. Following this instruction will commonly leave author unresolved (or guessed), which undermines the new requirement to systematically fill frontmatter from explicit sources.
Useful? React with 👍 / 👎.
|
|
||
| | Field | Source | | ||
| |-------|--------| | ||
| | `author` | Packagist JSON (`packagist.org/packages/<v>/<p>.json`) → `versions.dev-main.authors[0].name` | |
There was a problem hiding this comment.
The skill now requires versions.dev-main.authors[0].name, which breaks for packages that use a different branch key (for example dev-master) or only publish tagged versions. In those common cases the lookup returns nothing even though author data exists elsewhere in versions, so generated notes will miss author unnecessarily.
Useful? React with 👍 / 👎.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
.github/skills/laravel-research/SKILL.md (1)
47-64: Avoid duplicated mapping tables across agent and skill docs.This table duplicates
.github/agents/laravel-package.agent.mdand has already drifted in one field mapping. Consider centralizing this table in one canonical doc and linking to it from both files.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/skills/laravel-research/SKILL.md around lines 47 - 64, The frontmatter field mapping table in SKILL.md duplicates the same table in .github/agents/laravel-package.agent.md and has already drifted; remove the duplicate table from SKILL.md and replace it with a single canonical reference link to the centralized mapping document (create or choose one canonical file, e.g., a new or existing "field-mapping.md"), update both SKILL.md and .github/agents/laravel-package.agent.md to point to that canonical doc, and ensure the canonical table contains the authoritative mappings for `author`, `stars`, `latest_release`, `release_date`, `downloads_30d`, `announce_date`, `laravel_news_url`, `docs_url`, and `tags` and a note that all fields must be attempted.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/agents/laravel-package.agent.md:
- Line 50: Update the Packagist author extraction path used by the agent:
replace the non-versioned `authors[0].name` reference with the version-scoped
path (e.g. `versions.dev-main.authors[0].name`) so the `author` field is pulled
from the per-version metadata; locate the rule or mapping that defines `author`
(the entry currently pointing to `authors[0].name`) and change it to use the
`versions.<version>.authors[0].name` pattern (or a dynamic substitution for the
actual version key) to ensure accurate, version-scoped author extraction.
In @.steering/laravel-packages/zappzerapp__laravel-ingest.md:
- Around line 55-72: The example UserImporter getConfig uses Role::class but
fails to import Role; add the missing import e.g. add "use App\Models\Role;"
alongside the other top-of-file imports so Role is resolved in the UserImporter
class used in getConfig(), ensuring the snippet is runnable.
- Around line 9-12: The announce_date field is blank while laravel_news_url is
present; populate announce_date with the known publish date by setting
announce_date: 2026-04-07 (use the existing release_date value). Update the
metadata block so announce_date matches release_date and ensure the
announce_date, laravel_news_url, latest_release, and release_date fields remain
consistent.
---
Nitpick comments:
In @.github/skills/laravel-research/SKILL.md:
- Around line 47-64: The frontmatter field mapping table in SKILL.md duplicates
the same table in .github/agents/laravel-package.agent.md and has already
drifted; remove the duplicate table from SKILL.md and replace it with a single
canonical reference link to the centralized mapping document (create or choose
one canonical file, e.g., a new or existing "field-mapping.md"), update both
SKILL.md and .github/agents/laravel-package.agent.md to point to that canonical
doc, and ensure the canonical table contains the authoritative mappings for
`author`, `stars`, `latest_release`, `release_date`, `downloads_30d`,
`announce_date`, `laravel_news_url`, `docs_url`, and `tags` and a note that all
fields must be attempted.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: cda1a851-347c-4619-9463-58313ee341e3
📒 Files selected for processing (3)
.github/agents/laravel-package.agent.md.github/skills/laravel-research/SKILL.md.steering/laravel-packages/zappzerapp__laravel-ingest.md
|
|
||
| | Field | Source | | ||
| |-------|--------| | ||
| | `author` | Packagist (`packagist.org/packages/<vendor>/<package>.json` → `authors[0].name`) | |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
For Packagist package JSON responses, where is author data reliably located for a package version (e.g., dev-main): top-level authors[] or versions.dev-main.authors[]?
💡 Result:
Author metadata is reliably version-scoped: use versions["dev-main"]["authors"] (i.e., the authors field inside the specific version object), because Packagist’s package JSON returns versions as “the same data” as that version’s composer.json, and authors is a composer.json field. Do not rely on any top-level authors[] for per-version author data (it’s not the documented location for version metadata). [1], [2]
Sources:
[1] Packagist API docs (“versions”: same data as composer.json; dev versions via ~dev) https://packagist.org/apidoc?page=24&type=component
[2] Composer schema (authors field definition) https://getcomposer.org/doc/04-schema.md
Update Packagist author extraction path for version-scoped accuracy.
Line 50 currently references authors[0].name, which does not reliably contain per-version author data in Packagist responses. Per the Packagist API documentation and Composer schema, author metadata is version-scoped and must be extracted from versions.dev-main.authors[0].name instead. This mismatch between the documented path and the skill rule implementation will produce inconsistent results.
Suggested fix
-| `author` | Packagist (`packagist.org/packages/<vendor>/<package>.json` → `authors[0].name`) |
+| `author` | Packagist (`packagist.org/packages/<vendor>/<package>.json` → `versions.dev-main.authors[0].name`) |📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| | `author` | Packagist (`packagist.org/packages/<vendor>/<package>.json` → `authors[0].name`) | | |
| | `author` | Packagist (`packagist.org/packages/<vendor>/<package>.json` → `versions.dev-main.authors[0].name`) | |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/agents/laravel-package.agent.md at line 50, Update the Packagist
author extraction path used by the agent: replace the non-versioned
`authors[0].name` reference with the version-scoped path (e.g.
`versions.dev-main.authors[0].name`) so the `author` field is pulled from the
per-version metadata; locate the rule or mapping that defines `author` (the
entry currently pointing to `authors[0].name`) and change it to use the
`versions.<version>.authors[0].name` pattern (or a dynamic substitution for the
actual version key) to ensure accurate, version-scoped author extraction.
| announce_date: | ||
| latest_release: v0.5.3 (2026-04-07) | ||
| release_date: 2026-04-07 | ||
| laravel_news_url: https://laravel-news.com/laravel-ingest |
There was a problem hiding this comment.
Populate announce_date when laravel_news_url is present.
Line 9 is blank, but Line 12 provides a concrete Laravel News URL. Per your own field-resolution rule, this should be filled if the article has a publish date.
Suggested fix
-announce_date:
+announce_date: YYYY-MM-DD🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.steering/laravel-packages/zappzerapp__laravel-ingest.md around lines 9 -
12, The announce_date field is blank while laravel_news_url is present; populate
announce_date with the known publish date by setting announce_date: 2026-04-07
(use the existing release_date value). Update the metadata block so
announce_date matches release_date and ensure the announce_date,
laravel_news_url, latest_release, and release_date fields remain consistent.
|
@copilot Verify each finding against the current code and only fix it if needed. In @.steering/laravel-packages/zappzerapp__laravel-ingest.md around lines 55 - |
Agent-Logs-Url: https://github.com/ChrisThompsonTLDR/agentic-programming/sessions/1b8885ee-551b-4423-9639-04ec5a907242 Co-authored-by: ChrisThompsonTLDR <348801+ChrisThompsonTLDR@users.noreply.github.com>
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
There was a problem hiding this comment.
♻️ Duplicate comments (2)
.github/agents/laravel-package.agent.md (1)
50-50:⚠️ Potential issue | 🟠 MajorInconsistent author path: use version-scoped extraction.
Line 50 references
authors[0].name, but Packagist author metadata is version-scoped. This is inconsistent with the correct path in.github/skills/laravel-research/SKILL.mdline 53 (versions.dev-main.authors[0].name) and will produce unreliable results.🔧 Fix to align with SKILL.md and Packagist API
-| `author` | Packagist (`packagist.org/packages/<vendor>/<package>.json` → `authors[0].name`) | +| `author` | Packagist (`packagist.org/packages/<vendor>/<package>.json` → `versions.dev-main.authors[0].name`) |🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/agents/laravel-package.agent.md at line 50, The agent currently references packagist author as `authors[0].name` which is incorrect because Packagist author metadata is version-scoped; update the path to use the version-scoped field (e.g., `versions.<version>.authors[0].name` or match the SKILL.md usage `versions.dev-main.authors[0].name`) so the agent reads authors from the correct version entry and produces reliable results..steering/laravel-packages/zappzerapp__laravel-ingest.md (1)
9-9:⚠️ Potential issue | 🟡 MinorPopulate
announce_datewhenlaravel_news_urlis present.Line 9 is blank, but Line 12 provides a Laravel News URL. Per the field resolution rules defined in this PR, if a
laravel_news_urlexists, its publication date should be fetched and populated.🔍 Verification needed
Fetch the publication date from the Laravel News article and populate this field.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.steering/laravel-packages/zappzerapp__laravel-ingest.md at line 9, Populate the announce_date frontmatter when a laravel_news_url is present: detect the presence of the laravel_news_url field in .steering/laravel-packages/zappzerapp__laravel-ingest.md, fetch the article's publication date from that URL (HTTP GET + parse the article meta/date), and write the ISO-8601 date into the announce_date field in the file's frontmatter so the announce_date is no longer blank; ensure this runs wherever frontmatter resolution occurs and handle network/parse failures gracefully (log and skip) so existing behavior is preserved.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In @.github/agents/laravel-package.agent.md:
- Line 50: The agent currently references packagist author as `authors[0].name`
which is incorrect because Packagist author metadata is version-scoped; update
the path to use the version-scoped field (e.g.,
`versions.<version>.authors[0].name` or match the SKILL.md usage
`versions.dev-main.authors[0].name`) so the agent reads authors from the correct
version entry and produces reliable results.
In @.steering/laravel-packages/zappzerapp__laravel-ingest.md:
- Line 9: Populate the announce_date frontmatter when a laravel_news_url is
present: detect the presence of the laravel_news_url field in
.steering/laravel-packages/zappzerapp__laravel-ingest.md, fetch the article's
publication date from that URL (HTTP GET + parse the article meta/date), and
write the ISO-8601 date into the announce_date field in the file's frontmatter
so the announce_date is no longer blank; ensure this runs wherever frontmatter
resolution occurs and handle network/parse failures gracefully (log and skip) so
existing behavior is preserved.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: d60d2d8b-331d-43bd-a985-a36d78ba2fc0
📒 Files selected for processing (3)
.github/agents/laravel-package.agent.md.github/skills/laravel-research/SKILL.md.steering/laravel-packages/zappzerapp__laravel-ingest.md
The initial package note left
author,stars,downloads_30d,latest_release, andrelease_dateblank because the agent had no explicit guidance on where to source each field.Package note (
zappzerapp__laravel-ingest.md)IngestConfigbuilder pattern, not a facade chain)Agent & skill (
laravel-package.agent.md,SKILL.md)authorversions.dev-main.authors[0].namestarssearch_repositories→stargazers_countlatest_releaseget_latest_release→ formatvX.Y.Z (YYYY-MM-DD)release_dateget_latest_release→published_atdownloads_30dannounce_datetagstopics+ feature keywordsSummary by CodeRabbit