Open
Conversation
killenb
reviewed
Oct 16, 2025
killenb
reviewed
Nov 5, 2025
Member
killenb
left a comment
killenb
left a comment
There was a problem hiding this comment.
maybe we should make a static assert for the moment that the FixedPointConverter is only instantiated with int32_t?
Apart from that I think we are ready to merge to the master. I would do a full final review af the remaining issues are fixed (only did the delta of the comments and the commit, and lost the overview)
toseko
force-pushed
the
feat/tkozak-allow-different-rawdata-types
branch
from
a6c8cbf to
c566c84
Compare
killenb
reviewed
Nov 11, 2025
Comment on lines
+316
to
+319
| return numericToUserType<UserType>(f * *(std::bit_cast<uint32_t*>(&rawValue))); | ||
| } | ||
| else if constexpr(sizeof(RawType) == 8) { | ||
| return numericToUserType<UserType>(f * *(std::bit_cast<uint64_t*>(&rawValue))); |
Member
There was a problem hiding this comment.
These will start giving trouble if we have 64 bit values with more than 48 significant bits and negative fractional bits > -(64-nSignificant). I guess it's not a realistic scenario, but you would want 64 bit integer user type, which can hold the full resolution, but it is converted through double, which can only hold 48 significant bits.\
| #define SIGNED_HEX_TO_DOUBLE(INPUT) static_cast<double>(static_cast<int32_t>(INPUT)) | ||
| #define SIGNED_HEX_TO_INT64(INPUT) static_cast<int64_t>(static_cast<int32_t>(INPUT)) | ||
|
|
||
| #define SIGNED_HEX16_TO_DOUBLE(INPUT) static_cast<double>(static_cast<int16_t>(INPUT)) |
Member
There was a problem hiding this comment.
What about SIGNED_HEX64_TOxxx ?
killenb
force-pushed
the
feat/tkozak-allow-different-rawdata-types
branch
from
5932365 to
846c302
Compare
…he same fractional bit as size of the converter
killenb
force-pushed
the
feat/tkozak-allow-different-rawdata-types
branch
from
846c302 to
ba74da6
Compare
This is not allowed according to the TransferElement specification. Seems to be unused anyway.
When the provided initial values were not yet consistent, but a data update coming in turned them into a consistent set, the data made available to the user was corrupt, due to unnecessary buffer switch happening
toseko
force-pushed
the
feat/tkozak-allow-different-rawdata-types
branch
from
e193493 to
197b95a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.