Add tests for sorting over proj queryables with upstream OrderBy#9216
Merged
Conversation
# Conflicts: # src/HotChocolate/Data/src/Data/Sorting/Expressions/Extensions/QueryableSortContextExtensions.cs
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent generic method binding failures when applying sorting to a projected IQueryable that already has an upstream OrderBy (e.g., OrderBy(Foo).Select(Bar)), by ensuring existing ordering is only considered “applicable” when the ordered element type matches the current source element type.
Changes:
- Adds a regression test covering sorting on a projected queryable that already has an upstream
OrderBy. - Extends the test
Querywith a projected field and supporting model types/data to reproduce the scenario.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+108
to
+110
| { | ||
| projectedWithExistingOrder(order: { someProperty: DESC }) { | ||
| someProperty |
michaelstaib
changed the title
This was referenced Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5840