[Fusion] Pool the request cancellation source across operation executions#10080
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces per-request allocations in Fusion execution by reusing a pooled CancellationTokenSource to control (halt) the execution engine without cancelling the overall request pipeline, while still propagating request cancellation (client abort / shutdown) into the engine.
Changes:
- Reworked
OperationPlanExecutor.ExecuteAsyncto rent/return a pooled engineCancellationTokenSourceand dispose the request-token registration safely. - Added pooled engine cancellation management to
OperationPlanContext(RentEngineCancellation/ReturnEngineCancellation) and ensured it’s disposed when a context is destroyed.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/HotChocolate/Fusion/src/Fusion.Execution/Execution/OperationPlanExecutor.cs | Uses a pooled engine CTS + request-token registration with a try/finally to guarantee proper cleanup/reset. |
| src/HotChocolate/Fusion/src/Fusion.Execution/Execution/OperationPlanContext.Pooling.cs | Introduces a reusable engine CTS on the pooled context, with reset/replace logic and disposal on context destruction. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.