This repository was archived by the owner on Jan 5, 2026. It is now read-only.
Pass variables to replace tokens in query#1
Closed
rafatower wants to merge 2 commits into
Closed
Conversation
|
👍 Looks good to me. Are you also creating a PR upstream with these changes? |
Author
That's the idea. |
Author
|
Superseded by mapbox#248 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes mapbox#218
What this does:
mapnik::attributes varsto the mvt processor. It is a pretty open data structure used in other parts of mapnik & friends to pass tokens along.processor::update_tileto thetile_layer, so that it can set the variables of its associated query from there (an empty unordered map if not passed to the processor).(thanks @Algunenano for the advice on the constructor)
@Algunenano @javisantana can you please take a look?