Better game log UI: inline card images, improved verbosity presets#9889
Merged
tool4ever merged 9 commits intoCard-Forge:masterfrom Feb 23, 2026
Merged
Better game log UI: inline card images, improved verbosity presets#9889tool4ever merged 9 commits intoCard-Forge:masterfrom
tool4ever merged 9 commits intoCard-Forge:masterfrom
Conversation
- Replace 18 GameLogEntryType values with 3 intuitive presets (Low/Medium/High) via new GameLogVerbosity enum with tooltips explaining each level - Show miniature card images (50x70px) inline in log entries that reference a card, togglable via "Show Card Images" preference in Layout > View menu - Hovering over a card-linked log entry updates the card detail panel - Log zone changes for Battlefield->Graveyard/Exile (creature death, exile) - Add Prompt Options and Log Detail Level submenus to Layout > View menu - Add stay-open checkbox/radio button helpers to MenuUtil Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Settings combobox saves via toString() ("Medium") but LayoutMenu
compared with name() ("MEDIUM"). Use fromString() + enum identity
instead.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
tool4ever
reviewed
Feb 23, 2026
forge-gui/src/main/java/forge/localinstance/properties/ForgePreferences.java
Show resolved
Hide resolved
Hanmac
reviewed
Feb 23, 2026
Adds a CUSTOM option to GameLogVerbosity that reveals a submenu of individual checkboxes for each GameLogEntryType, giving power users fine-grained control while keeping preset simplicity for beginners. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Reduces boilerplate for this simple immutable data carrier. Updates 9 field-access sites to use record accessor methods. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Hanmac
reviewed
Feb 23, 2026
Use Title Case consistently for all display captions: Game Outcome, Match Result, Player Control, Resolve Stack, Add To Stack. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace the in-game custom categories dropdown submenu with a dialog popup. Add a "Custom Game Log Settings..." button to the Preferences Advanced section, enabled only when Custom verbosity is selected. Also make Preferences note labels support text wrapping. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When CUSTOM log verbosity is selected, a new settings item opens a scrollable checkbox dialog to configure which GameLogEntryType categories are included. The item greys out when a non-CUSTOM verbosity is active. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes four changes to improve the in-match log panel, particularly on desktop.
Inline Card Images — Log entries that reference a card now show a miniature card image (50x70px) on the left, modelled on the existing stack panel's
StackInstanceTextAreapattern. UsesCachedCardImagefor async loading. Togglable via Layout > View > Log Detail Level > Show Card Images.Card Hover — Hovering over a card-linked log entry updates the card detail panel and card view panel, same as hovering over stack items. Face-down cards are guarded (no detail shown).
Clearer log verbosity settings — Currently the log verbosity setting exposes all 18 internal
GameLogEntryTypevalues in a flat list. Most players don't know what "STACK_ADD" or "ZONE_CHANGE" means, and the ordinal cutoff filter means you can't include damage without also including everything above it.PR replaces the 18-item list with three intuitive presets:
Old preference values are migrated automatically.
The verbosity setting only affects the in-game UI log panel, not text game log output.
ZONE_CHANGEentries, visible at Medium and above.Desktop gets all features 1 - 4, as 1 and 2 are based on existing stack/card view functionality.
Mobile gets features 3 and 4 only.
🤖 Generated with Claude Code