Improve permission request flow and recording events#1479
Merged
richiemcilroy merged 12 commits intomainfrom Jan 1, 2026
Merged
Improve permission request flow and recording events#1479richiemcilroy merged 12 commits intomainfrom
richiemcilroy merged 12 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Additional Comments (4)
-
apps/desktop/src/components/ModeSelect.tsx, line 31 (link)syntax: Missing import for
IconLucideCheckwhich is used in the selected state indicator -
apps/desktop/src/components/ModeSelect.tsx, line 69-81 (link)syntax: Missing imports for
IconCapInstant,IconCapFilmCut, andIconCapScreenshoticons used in mode options -
apps/desktop/src/components/ModeSelect.tsx, line 101 (link)syntax: Missing import for
IconCapXused in the close button -
apps/desktop/src/routes/(window-chrome)/setup.tsx, line 354 (link)syntax: Missing import for
IconLucideVolume2- this will cause a runtime error when the mute button is not active
15 files reviewed, 4 comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
Important Files Changed
Confidence score: 4/5
Sequence Diagram
sequenceDiagram participant User participant Hotkeys participant Recording participant RecordingActor participant Frontend User->>Hotkeys: "Press pause hotkey" Hotkeys->>Recording: "toggle_pause_recording()" Recording->>RecordingActor: "is_paused().await" RecordingActor-->>Recording: "paused status" alt Recording is paused Recording->>RecordingActor: "resume().await" RecordingActor-->>Recording: "Ok(())" Recording->>Frontend: "emit RecordingEvent::Resumed" else Recording is active Recording->>RecordingActor: "pause().await" RecordingActor-->>Recording: "Ok(())" Recording->>Frontend: "emit RecordingEvent::Paused" endContext used:
dashboard- CLAUDE.md (source)dashboard- AGENTS.md (source)