Simplify system stop error check in macOS screen capture

[richiemcilroy]

Summary by CodeRabbit

• Bug Fixes
  • Improved screen recording error handling on macOS to more reliably detect and recover from system-initiated stream interruptions.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The is_system_stop_error function in the macOS screen capture module was simplified by removing a domain-based check. The function now identifies system stop errors solely by matching the localized error description "Stream was stopped by the system", regardless of the error's domain.

Changes

Cohort / File(s)	Change Summary
macOS error handling simplification crates/recording/src/sources/screen_capture/macos.rs	Removed domain verification from is_system_stop_error function; now any error with localized description "Stream was stopped by the system" is classified as a system stop error.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Verify that removing the domain check does not cause false positives in error classification from unrelated system components
• Confirm the impact on error-handling monitor restart behavior across different error sources

Poem

🐰 A domain fell away, plain and clear,
Now errors speak their truth without fear—
"Stream stopped by system," the message rings true,
No need to check doors when the answer shines through! ✨

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch more-recording-fixes

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4a7985b and 268eecb.

📒 Files selected for processing (1)

• crates/recording/src/sources/screen_capture/macos.rs (0 hunks)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}