Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2019 +/- ##
==========================================
+ Coverage 95.00% 95.69% +0.69%
==========================================
Files 30 30
Lines 8742 9091 +349
Branches 1298 1357 +59
==========================================
+ Hits 8305 8700 +395
+ Misses 289 239 -50
- Partials 148 152 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@adam-urbanczyk I've restarted the MacOS CI job 4 times and it keeps failing. Restarting once or twice is normally enough. |
|
Yup. For some reason mypy fails to start. I'll investigate. |
|
I'll still investgate what's breaking with the newest mypy |
|
Just in case: this PR is ready for review. |
jmwright
left a comment
There was a problem hiding this comment.
Other than the comment made by @lorenzncode and the one comment I left about the if/elif logic, this looks good to me. Thanks @adam-urbanczyk !
… into nurbs-extensions
Quite some improvements for the NURBS module.
Surface,Curveand their control points visfig.showandshowconstrainedApproximate2D