fix: [marked] Upgrade marked from 0.3.5 to 0.3.6 to resolve CVE-2016-10531 (XSS)#68
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Conversation
Snyk High (CVSS 8.8) npm:marked:20150520. Fixes Cross-site Scripting via crafted markdown; marked is used in app.js for rendering todo content. Co-Authored-By: Hannah Huh <hannah.huh@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the highest-CVSS High (8.8) finding with a known non-breaking fix, surfaced by a Snyk SCA scan.
marked@0.3.5is vulnerable to Cross-site Scripting (XSS) —CVE-2016-10531/ npm:marked:20150520 — via crafted markdown that bypasses sanitization.markedis a direct dependency used to render user-controlled todo content inapp.js:Fix = bump the direct dependency to the patched release (
fixedIn: 0.3.6):0.3.6 keeps the
setOptions({sanitize})+marked(string)API used here, so no code changes are required.Verification
snyk testafter the upgrade confirmsCVE-2016-10531is resolved.Note (out of scope):
markedhas additional, later-disclosed issues that are only fully cleared by a major upgrade (0.7+/4.x), which removes thesanitizeoption and changes the render API — requiring code changes. Tracked as a follow-up; this PR is scoped to the targeted CVE per one-vuln-per-PR.One vulnerability per PR (Scheduled Snyk MCP scan, remediation phase).
Link to Devin session: https://app.devin.ai/sessions/3de7e286bad14ebb88618cf08a9489ab
Requested by: @hannahhuh-cog
Devin Review