fix: [sha.js] Pin sha.js to 2.4.12 to resolve CVE-2025-9288 (missing input type check)#67
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Conversation
…9288 Snyk Critical (CVSS 9.1) SNYK-JS-SHAJS-12089400. Vulnerable sha.js@2.4.11 is pulled via typeorm; an npm override forces the patched 2.4.12 (missing type check on input). Co-Authored-By: Hannah Huh <hannah.huh@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves a Critical (CVSS 9.1) vulnerability in
sha.js, surfaced by a Snyk SCA scan.sha.js@2.4.11performs a hash update without validating the argument type —CVE-2025-9288/ SNYK-JS-SHAJS-12089400 ("Function Call With Incorrect Argument Type"), which can lead to hash-rewind / incorrect digest behaviour. It is pulled in transitively via a direct dependency:typeormrequiressha.js@^2.4.11, so the patched2.4.12is a drop-in (same major.minor). An npmoverridesscoped totypeormforces it:Verification
After the change,
snyk testreportssha.js@2.4.12and 0 remainingsha.jsissues.One vulnerability per PR (Scheduled Snyk MCP scan, remediation phase).
Link to Devin session: https://app.devin.ai/sessions/3de7e286bad14ebb88618cf08a9489ab
Requested by: @hannahhuh-cog
Devin Review