fix: [adm-zip] Upgrade adm-zip from 0.4.7 to 0.5.16 to resolve CVE-2018-1002204 (Zip Slip)#64
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Conversation
…02204) Snyk Critical (CVSS 9.4) SNYK: npm:adm-zip:20180415. Fixes Arbitrary File Write via Archive Extraction and Directory Traversal (SNYK-JS-ADMZIP-1065796). Co-Authored-By: Hannah Huh <hannah.huh@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves a Critical (CVSS 9.4) Zip Slip vulnerability surfaced by a Snyk SCA scan of this repo.
adm-zip@0.4.7is vulnerable to Arbitrary File Write via Archive Extraction (Zip Slip) —CVE-2018-1002204/npm:adm-zip:20180415. A crafted.zipwith entry names like../../evilcan write files outside the intended extraction directory. This repo triggers it directly inroutes/index.js:Fix = bump the direct dependency to a patched release:
0.5.x adds path-traversal protection in
extractAllTo. TheAdmZip(buffer)/extractAllTo(path, overwrite)API used here is unchanged, so no code changes are required. This also clears the related HighDirectory Traversal(SNYK-JS-ADMZIP-1065796, fixed in 0.5.2).Verification
snyk testafter the upgrade reports 0 remainingadm-zipissues (previously 1 Critical + 1 High).One vulnerability per PR (Scheduled Snyk MCP scan, remediation phase).
Link to Devin session: https://app.devin.ai/sessions/3de7e286bad14ebb88618cf08a9489ab
Requested by: @hannahhuh-cog
Devin Review