fix: [marked] Upgrade marked from 0.3.5 to 0.3.6 to resolve CVE-2016-10531 (ReDoS)#50
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Conversation
…egex (CVE-2016-10531) Co-Authored-By: Hannah Huh <hannah.huh@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Regular Expression Denial of Service (ReDoS) vulnerability in
marked@0.3.5(CVSS 8.8 — highest-CVSS High finding,CVE-2016-10531). A crafted heading in attacker-controlled markdown triggers catastrophic backtracking inmarked's heading regex, hanging the event loop.markedis a direct dependency used to render markdown in the app.0.3.6is the Snyk-recommended patched release for this CVE and is a drop-in within the0.3.xline (no API change to themarked(text)calls).package-lock.jsonregenerated →marked@0.3.6.Verified locally:
snyk testparses the lockfile and no longer reportsCVE-2016-10531.9e26acce-22c7-4efc-b470-21d9587f49fe, projectgoof(npm)Note:
marked@0.3.xcarries additional later CVEs that need amarked4.x major upgrade (breaking API); tracked as follow-up. This PR is scoped to the single targeted CVE. Part of a set of 5 fix PRs for the top findings.Link to Devin session: https://app.devin.ai/sessions/d6b18d8e5ad94506b760971485ceb694
Requested by: @hannahhuh-cog
Devin Review