Skip to content

fix: [sha.js] Upgrade sha.js from 2.4.11 to 2.4.12 to resolve CVE-2025-9288 (Missing Type Checks)#49

Open
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1782325851-fix-sha-js-cve-2025-9288
Open

fix: [sha.js] Upgrade sha.js from 2.4.11 to 2.4.12 to resolve CVE-2025-9288 (Missing Type Checks)#49
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1782325851-fix-sha-js-cve-2025-9288

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Jun 24, 2026

Copy link
Copy Markdown

Summary

Fixes the Function Call With Incorrect Argument Type vulnerability in sha.js@2.4.11 (CVSS 9.1, CVE-2025-9288). sha.js does not validate input types, so passing a non-string/non-Buffer can corrupt the internal hashing state and produce incorrect/forgeable digests (hash bypass).

sha.js@2.4.11 is transitive (typeorm > ... > sha.js). To avoid a typeorm major upgrade, this pins it via an npm overrides entry to the patched release:

+"overrides": {
+  "sha.js": "2.4.12"
+}

2.4.12 is the patch release that adds the missing type checks; it is a drop-in for 2.4.11. package-lock.json regenerated → single sha.js@2.4.12 resolution.

Verified locally: snyk test parses the lockfile and reports 0 remaining sha.js vulnerabilities.

One vulnerability per PR; part of a set of 5 fix PRs for the top findings.

Link to Devin session: https://app.devin.ai/sessions/d6b18d8e5ad94506b760971485ceb694
Requested by: @hannahhuh-cog


Devin Review

Status Commit
⚪ Not started

Run Devin Review

Open in Devin Review (Staging)

…ash bypass (CVE-2025-9288)

Co-Authored-By: Hannah Huh <hannah.huh@cognition.ai>
@devin-ai-integration

Copy link
Copy Markdown
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants